[jira] [Commented] (MESOS-7397) apply-reviews.py silently fails when using chain mode.

["Till Toenshoff (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535835#comment-16535835 ] 

Till Toenshoff commented on MESOS-7397:
---------------------------------------

Nope, still fails for me.
 # Do a {{git show}}.
 # Note the review request number (WHATEVER_RR_THAT_WAS).
 # Do a {{git reset --hard HEAD^}}
 # Do a {{support/apply-reviews.sh  -c -r WHATEVER_RR_THAT_WAS}}

You will get a warning that this review had already been applied while nothing was applied.

 

> apply-reviews.py silently fails when using chain mode.
> ------------------------------------------------------
>
>                 Key: MESOS-7397
>                 URL: https://issues.apache.org/jira/browse/MESOS-7397
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Till Toenshoff
>            Assignee: Shubham Kumar
>            Priority: Minor
>
> When using {{apply-reviews.py}} in chain mode {{--chain}} it suppresses error messages when patches do not apply.
> Example on {{1.0.x}}:
> {noformat}
> $ ./support/apply-reviews.py -c -r 57764
> $
> {noformat} 
> If used without chain mode, the error message is properly displayed:
> {noformat}
> $ ./support/apply-reviews.py -r 57764
> 2017-04-18 11:45:58 URL:https://reviews.apache.org/r/57764/diff/raw/ [1067/1067] -> "57764.patch" [1]
> error: patch failed: src/launcher/posix/executor.cpp:116
> error: src/launcher/posix/executor.cpp: patch does not apply
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)