[GitHub] [spark] srowen commented on a diff in pull request #37478: [SPARK][SQL] feat: conf(String, Any)

[GitBox <gi...@apache.org>]

srowen commented on code in PR #37478:
URL: https://github.com/apache/spark/pull/37478#discussion_r946784170


##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -854,11 +857,23 @@ object SparkSession extends Logging {
      *
      * @since 2.0.0
      */
+    @deprecated("use conf", "3.3.1")
     def config(key: String, value: Boolean): Builder = synchronized {
       options += key -> value.toString
       this
     }
 
+    /**
+     * Sets a config option. Options set using this method are automatically propagated to
+     * both `SparkConf` and SparkSession's own configuration.
+     *
+     * @since 3.3.1
+     */
+    def conf(key: String, value: Any): Builder = synchronized {

Review Comment:
   Hm, does this work from Java? I'm concerned that this method becomes harder to use outside Scala



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org