You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/09/24 15:30:03 UTC
[jira] [Commented] (PHOENIX-4835) LoggingPhoenixConnection should
log metrics upon connection close
[ https://issues.apache.org/jira/browse/PHOENIX-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626008#comment-16626008 ]
Hudson commented on PHOENIX-4835:
---------------------------------
FAILURE: Integrated in Jenkins build Phoenix-omid2 #89 (See [https://builds.apache.org/job/Phoenix-omid2/89/])
PHOENIX-4835 LoggingPhoenixConnection should log metrics upon connection (karanmehta93: rev eb79c5b11b95bcd261c150ecd0f709712be2217c)
* (add) phoenix-core/src/it/java/org/apache/phoenix/monitoring/BasePhoenixMetricsIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/LoggingPhoenixConnection.java
* (add) phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java
> LoggingPhoenixConnection should log metrics upon connection close
> -----------------------------------------------------------------
>
> Key: PHOENIX-4835
> URL: https://issues.apache.org/jira/browse/PHOENIX-4835
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Karan Mehta
> Assignee: Karan Mehta
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-4835.4.x-HBase-1.4.001.patch, PHOENIX-4835.4.x-HBase-1.4.002.patch
>
>
> {{LoggingPhoenixConnection}} currently logs metrics upon {{commit()}}, which may miss the logging of metrics sometimes if commit is never called. We should move it to {{close()}} method instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)