You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Felix Knecht <fe...@otego.com> on 2010/05/14 22:05:41 UTC
Intermediate reports of Shared-/Apacheds-Project
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
For interested people
I created for the shared [1] and the apacheds [2] project the report
site for svn trunk.
Apart from the reports about newer versions of
plugins/dependencies/properties following reports may be of a special
interest (each module has the reports on its own):
- - Cobertura Test Coverage
(e.g.
http://people.apache.org/~felixk/apacheds-docs/apacheds-xdbm-base/cobertura/index.html)
- - Findbugs Report, specially the ones with high priority
(e.g.
http://people.apache.org/~felixk/apacheds-docs/apacheds-core/findbugs.html).
Regards
Felix
[1] http://people.apache.org/~felixk/shared-docs/
[2] http://people.apache.org/~felixk/apacheds-docs/
PS:
apacheds-docs are still beeing deployed. Hopefully also all available
tomorrow
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkvtrRUACgkQ2lZVCB08qHEtBwCfYuinR4dxRBvhrAhf90zhVV9Z
s4gAoK3F82Aj45cfIckFZDZy8SaTd33y
=oIZZ
-----END PGP SIGNATURE-----
Re: Intermediate reports of Shared-/Apacheds-Project
Posted by Emmanuel Lecharny <el...@gmail.com>.
On 5/14/10 10:05 PM, Felix Knecht wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> For interested people
>
> I created for the shared [1] and the apacheds [2] project the report
> site for svn trunk.
>
> Apart from the reports about newer versions of
> plugins/dependencies/properties following reports may be of a special
> interest (each module has the reports on its own):
>
> - - Cobertura Test Coverage
> (e.g.
> http://people.apache.org/~felixk/apacheds-docs/apacheds-xdbm-base/cobertura/index.html)
>
> - - Findbugs Report, specially the ones with high priority
> (e.g.
> http://people.apache.org/~felixk/apacheds-docs/apacheds-core/findbugs.html).
>
Many thanks, Felix !
As usual, this is very valuable pieces of information ! Keep going, we
will try to fix maany of those problems in the near future !
--
Regards,
Cordialement,
Emmanuel Lécharny
www.nextury.com
Re: Intermediate reports of Shared-/Apacheds-Project
Posted by Stefan Seelmann <se...@apache.org>.
Felix Knecht wrote:
> For interested people
>
> I created for the shared [1] and the apacheds [2] project the report
> site for svn trunk.
>
> Apart from the reports about newer versions of
> plugins/dependencies/properties following reports may be of a special
> interest (each module has the reports on its own):
>
> - Cobertura Test Coverage
> (e.g.
> http://people.apache.org/~felixk/apacheds-docs/apacheds-xdbm-base/cobertura/index.html)
I'll add some tests to xdbm-base.
Kind Regards,
Stefan
Re: Intermediate reports of Shared-/Apacheds-Project
Posted by Emmanuel Lecharny <el...@gmail.com>.
On 5/14/10 11:05 PM, Felix Knecht wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> IIRC checkstyle report has never been configured for our used style.
> Maybe we should comment the checkstyle report until we do have a
> definition which fits our wishes?
>
Sure !
What we can do is to remove the few errors I have mentionned, as they
probably represent 95% of all the errors we have,
then incrementally tune the config. I don't think such a process will
take tens of iterations.
> IMO findbugs report should have a higher priority than checkstyle as we
> can find problems like
>
Yep. Checkstye is just about style, all in all. Findbugs already saved
us in many cases, as it's able to detect potential NPE or other major
issues.
--
Regards,
Cordialement,
Emmanuel Lécharny
www.nextury.com
Re: Intermediate reports of Shared-/Apacheds-Project
Posted by Felix Knecht <fe...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
IIRC checkstyle report has never been configured for our used style.
Maybe we should comment the checkstyle report until we do have a
definition which fits our wishes?
IMO findbugs report should have a higher priority than checkstyle as we
can find problems like
instanceof will always return false in
org.apache.directory.server.core.DefaultDirectoryService.showSecurityWarnings(),
since a org.apache.directory.shared.ldap.entry.Value can't be a byte[]
(http://findbugs.sourceforge.net/bugDescriptions.html#BC_IMPOSSIBLE_INSTANCEOF)
Inconsistent synchronization of
org.apache.directory.server.core.DefaultDirectoryService.started; locked
50% of time
(http://findbugs.sourceforge.net/bugDescriptions.html#IS2_INCONSISTENT_SYNC)
Write to static field
org.apache.directory.server.core.authz.DefaultAuthorizationInterceptor.USER_BASE_DN
from instance method
(http://findbugs.sourceforge.net/bugDescriptions.html#ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
Felix
On 05/14/10 22:53, Emmanuel Lecharny wrote:
> As I was looking at the shared asn1.codec checkstyle errors, I think we
> should tune it to remove useless errors :
> - Line has trailing spaces
> - Line is longer than 80 characters. (should set a new limit at 128...
> We are not anymore using a VT100 terminal to code :)
> - '{' should be on the previous line : In fact, we selected this format.
> '{' must be on a new line.
> - '(' is followed by whitespace. Again, this is a format choice. I would
> rather get a warning if it's not the case
> - ')' is preceded with whitespace. Same as above
> - Parameter decoder should be final. I hate this constraints. I know
> it's a kind of trick to protect the parameter from being modified inside
> the method, but IMHO, it bloats the methods declaration Now, it may be
> just me ...
>
> I didn't checked all the reports, but if we tune CheckStyle to change
> those parameters, we will have hundreds (thousands ?) or removed errors.
>
> wdyt ?
>
>
> On 5/14/10 10:05 PM, Felix Knecht wrote:
> For interested people
>
> I created for the shared [1] and the apacheds [2] project the report
> site for svn trunk.
>
> Apart from the reports about newer versions of
> plugins/dependencies/properties following reports may be of a special
> interest (each module has the reports on its own):
>
> - Cobertura Test Coverage
> (e.g.
> http://people.apache.org/~felixk/apacheds-docs/apacheds-xdbm-base/cobertura/index.html)
>
>
> - Findbugs Report, specially the ones with high priority
> (e.g.
> http://people.apache.org/~felixk/apacheds-docs/apacheds-core/findbugs.html).
>
>
>
> Regards
> Felix
>
> [1] http://people.apache.org/~felixk/shared-docs/
> [2] http://people.apache.org/~felixk/apacheds-docs/
>
> PS:
> apacheds-docs are still beeing deployed. Hopefully also all available
> tomorrow
>>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkvtuwYACgkQ2lZVCB08qHHBDQCgzzsr5e1c1okG4SJ6j0NAhCUS
BFYAn1nJHUrfyE9yphPTNNTQdaTONCJd
=+nnx
-----END PGP SIGNATURE-----
Re: Intermediate reports of Shared-/Apacheds-Project
Posted by Emmanuel Lecharny <el...@gmail.com>.
As I was looking at the shared asn1.codec checkstyle errors, I think
we should tune it to remove useless errors :
- Line has trailing spaces
- Line is longer than 80 characters. (should set a new limit at 128...
We are not anymore using a VT100 terminal to code :)
- '{' should be on the previous line : In fact, we selected this format.
'{' must be on a new line.
- '(' is followed by whitespace. Again, this is a format choice. I would
rather get a warning if it's not the case
- ')' is preceded with whitespace. Same as above
- Parameter decoder should be final. I hate this constraints. I know
it's a kind of trick to protect the parameter from being modified inside
the method, but IMHO, it bloats the methods declaration Now, it may be
just me ...
I didn't checked all the reports, but if we tune CheckStyle to change
those parameters, we will have hundreds (thousands ?) or removed errors.
wdyt ?
On 5/14/10 10:05 PM, Felix Knecht wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> For interested people
>
> I created for the shared [1] and the apacheds [2] project the report
> site for svn trunk.
>
> Apart from the reports about newer versions of
> plugins/dependencies/properties following reports may be of a special
> interest (each module has the reports on its own):
>
> - - Cobertura Test Coverage
> (e.g.
> http://people.apache.org/~felixk/apacheds-docs/apacheds-xdbm-base/cobertura/index.html)
>
> - - Findbugs Report, specially the ones with high priority
> (e.g.
> http://people.apache.org/~felixk/apacheds-docs/apacheds-core/findbugs.html).
>
>
> Regards
> Felix
>
> [1] http://people.apache.org/~felixk/shared-docs/
> [2] http://people.apache.org/~felixk/apacheds-docs/
>
> PS:
> apacheds-docs are still beeing deployed. Hopefully also all available
> tomorrow
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.15 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkvtrRUACgkQ2lZVCB08qHEtBwCfYuinR4dxRBvhrAhf90zhVV9Z
> s4gAoK3F82Aj45cfIckFZDZy8SaTd33y
> =oIZZ
> -----END PGP SIGNATURE-----
>
>
--
Regards,
Cordialement,
Emmanuel Lécharny
www.nextury.com