You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Yurii Shylov <yu...@gmail.com> on 2014/11/17 19:28:51 UTC

Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-8353
    https://issues.apache.org/jira/browse/AMBARI-8353


Repository: ambari


Description
-------

Add stack_versions subresource to /hosts and /clusters 


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
  ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
  ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 

Diff: https://reviews.apache.org/r/28124/diff/


Testing
-------

in progress


Thanks,

Yurii Shylov

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Nate Cole <nc...@hortonworks.com>.


> On Nov. 17, 2014, 3:49 p.m., Nate Cole wrote:
> > Is there a need for two different types?  A repo_version on a host vs cluster should look the same, no?
> 
> Alejandro Fernandez wrote:
>     Technically, there is a difference because the Cluster is required to have exactly one stack version in the CURRENT state, whereas a Host may be doing a rolling upgrade and have multiple stack versions INSTALLED, but only switch one of them to CURRENT after a stack-select (such as HDP-select script) has moved all symlinks and no Jobs in the previous stack remain. The difference is so minor that I'm ok with consolidating the UpgradeState and ClusterVersionState enums.

I meant in the context of the API.  This patch is definining 2 new types for a stack_version subresource (Resource.Type.ClusterStackVersion and Resource.Type.HostStackVersion).  Can it be ONE type for BOTH hosts and clusters if they return nearly the same elements (say, RepositoryVersion or something)?  I'm not referring to state, version state and upgrade state should remain separate.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61803
-----------------------------------------------------------


On Nov. 17, 2014, 1:28 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 1:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Alejandro Fernandez <af...@hortonworks.com>.


> On Nov. 17, 2014, 8:49 p.m., Nate Cole wrote:
> > Is there a need for two different types?  A repo_version on a host vs cluster should look the same, no?
> 
> Alejandro Fernandez wrote:
>     Technically, there is a difference because the Cluster is required to have exactly one stack version in the CURRENT state, whereas a Host may be doing a rolling upgrade and have multiple stack versions INSTALLED, but only switch one of them to CURRENT after a stack-select (such as HDP-select script) has moved all symlinks and no Jobs in the previous stack remain. The difference is so minor that I'm ok with consolidating the UpgradeState and ClusterVersionState enums.
> 
> Nate Cole wrote:
>     I meant in the context of the API.  This patch is definining 2 new types for a stack_version subresource (Resource.Type.ClusterStackVersion and Resource.Type.HostStackVersion).  Can it be ONE type for BOTH hosts and clusters if they return nearly the same elements (say, RepositoryVersion or something)?  I'm not referring to state, version state and upgrade state should remain separate.

I see what you mean. One can certainly extend the other. For example, the subresource for cluster will have additional properties for "installed on hosts", "current on hosts".


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61803
-----------------------------------------------------------


On Nov. 17, 2014, 6:28 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 6:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Yurii Shylov <yu...@gmail.com>.


> On Ноя. 17, 2014, 8:49 п.п., Nate Cole wrote:
> > Is there a need for two different types?  A repo_version on a host vs cluster should look the same, no?
> 
> Alejandro Fernandez wrote:
>     Technically, there is a difference because the Cluster is required to have exactly one stack version in the CURRENT state, whereas a Host may be doing a rolling upgrade and have multiple stack versions INSTALLED, but only switch one of them to CURRENT after a stack-select (such as HDP-select script) has moved all symlinks and no Jobs in the previous stack remain. The difference is so minor that I'm ok with consolidating the UpgradeState and ClusterVersionState enums.
> 
> Nate Cole wrote:
>     I meant in the context of the API.  This patch is definining 2 new types for a stack_version subresource (Resource.Type.ClusterStackVersion and Resource.Type.HostStackVersion).  Can it be ONE type for BOTH hosts and clusters if they return nearly the same elements (say, RepositoryVersion or something)?  I'm not referring to state, version state and upgrade state should remain separate.
> 
> Alejandro Fernandez wrote:
>     I see what you mean. One can certainly extend the other. For example, the subresource for cluster will have additional properties for "installed on hosts", "current on hosts".

Besides additional properties, there should be also support for PUT request later for ClusterStackVersion. Besides that, I had the similar experience with PrivilegeResourceProvider which was also made generic. Personally I think that it has brought only unnecessary complications, it has became more difficult to support it or to modify custom implementations of that API.


- Yurii


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61803
-----------------------------------------------------------


On Ноя. 18, 2014, 12:36 п.п., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Ноя. 18, 2014, 12:36 п.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Nate Cole <nc...@hortonworks.com>.


> On Nov. 17, 2014, 3:49 p.m., Nate Cole wrote:
> > Is there a need for two different types?  A repo_version on a host vs cluster should look the same, no?
> 
> Alejandro Fernandez wrote:
>     Technically, there is a difference because the Cluster is required to have exactly one stack version in the CURRENT state, whereas a Host may be doing a rolling upgrade and have multiple stack versions INSTALLED, but only switch one of them to CURRENT after a stack-select (such as HDP-select script) has moved all symlinks and no Jobs in the previous stack remain. The difference is so minor that I'm ok with consolidating the UpgradeState and ClusterVersionState enums.
> 
> Nate Cole wrote:
>     I meant in the context of the API.  This patch is definining 2 new types for a stack_version subresource (Resource.Type.ClusterStackVersion and Resource.Type.HostStackVersion).  Can it be ONE type for BOTH hosts and clusters if they return nearly the same elements (say, RepositoryVersion or something)?  I'm not referring to state, version state and upgrade state should remain separate.
> 
> Alejandro Fernandez wrote:
>     I see what you mean. One can certainly extend the other. For example, the subresource for cluster will have additional properties for "installed on hosts", "current on hosts".
> 
> Yurii Shylov wrote:
>     Besides additional properties, there should be also support for PUT request later for ClusterStackVersion. Besides that, I had the similar experience with PrivilegeResourceProvider which was also made generic. Personally I think that it has brought only unnecessary complications, it has became more difficult to support it or to modify custom implementations of that API.

The definition can be shared, even if the resource provider is separate.  You can see how to do a conditional check in ResourceInstanceFactoryImpl.java, look for ViewInstance.  Based on the keys passed in, decide which resource provider to instantiate.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61803
-----------------------------------------------------------


On Nov. 18, 2014, 7:36 a.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 7:36 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Alejandro Fernandez <af...@hortonworks.com>.


> On Nov. 17, 2014, 8:49 p.m., Nate Cole wrote:
> > Is there a need for two different types?  A repo_version on a host vs cluster should look the same, no?

Technically, there is a difference because the Cluster is required to have exactly one stack version in the CURRENT state, whereas a Host may be doing a rolling upgrade and have multiple stack versions INSTALLED, but only switch one of them to CURRENT after a stack-select (such as HDP-select script) has moved all symlinks and no Jobs in the previous stack remain. The difference is so minor that I'm ok with consolidating the UpgradeState and ClusterVersionState enums.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61803
-----------------------------------------------------------


On Nov. 17, 2014, 6:28 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 6:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61803
-----------------------------------------------------------


Is there a need for two different types?  A repo_version on a host vs cluster should look the same, no?

- Nate Cole


On Nov. 17, 2014, 1:28 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 1:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Yurii Shylov <yu...@gmail.com>.


> On Ноя. 18, 2014, 11:38 д.п., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java, line 143
> > <https://reviews.apache.org/r/28124/diff/1/?file=765972#file765972line143>
> >
> >     As of now, RepositoryVersionEntity seems to restrict repository version values only to those that are installed for a stack, right?
> >     I consider the workflow when host contains some stale repo files that remained after server reset or after previous cluster deployment. Are we able to display via API stale repository versions that are installed on a host?

Right now RepositoryVersions are populated only manually through the API, they do not analyze hosts for existing repos. Later it will be added to bootstrap and upgrade workflows, but still it won't be possible to know the original source for repos, so the json for them will be empty. That is why there is a null check for repo version at this place.


- Yurii


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61900
-----------------------------------------------------------


On Ноя. 18, 2014, 12:36 п.п., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Ноя. 18, 2014, 12:36 п.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61900
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
<https://reviews.apache.org/r/28124/#comment103828>

    As of now, RepositoryVersionEntity seems to restrict repository version values only to those that are installed for a stack, right?
    I consider the workflow when host contains some stale repo files that remained after server reset or after previous cluster deployment. Are we able to display via API stale repository versions that are installed on a host?


- Dmitro Lisnichenko


On Nov. 17, 2014, 6:28 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 6:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Yurii Shylov <yu...@gmail.com>.


> On Ноя. 18, 2014, 12:54 д.п., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java, lines 60-63
> > <https://reviews.apache.org/r/28124/diff/1/?file=765969#file765969line60>
> >
> >     No need.  Each provider can live on its own.

Will fix it


- Yurii


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61845
-----------------------------------------------------------


On Ноя. 18, 2014, 12:36 п.п., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Ноя. 18, 2014, 12:36 п.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61845
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
<https://reviews.apache.org/r/28124/#comment103755>

    Don't do this.  Each ResourceProvider can live on its own without a definition in ControllerModule



ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
<https://reviews.apache.org/r/28124/#comment103756>

    No need.  Each provider can live on its own.


- Nate Cole


On Nov. 17, 2014, 1:28 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 1:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by John Speidel <js...@hortonworks.com>.


> On Nov. 17, 2014, 8:08 p.m., John Speidel wrote:
> > -1
> > Please dion't merge this.
> > 
> > Please point to a design document for this api addition or documentation that describes the details of this api and why it is needed.
> > Most of this information is already available via the api.
> > 
> > Also, please include Tom Beerbower in all API related reviews.
> 
> Nate Cole wrote:
>     John, no this is something different.  This effort is to support rolling upgrades of a cluster, where we have to maintain version information for a cluster.  In addition, we are also going to be tracking which versions have been installed on hosts.  This is a major feature of 2.0.0 and has already been through significant design.  Having said that, I've made comments to see if this patch can be simplified a bit.

Nate,
My primary concern was that this is a significant api addition that Tom didn't know about and has no supporting documentation.  Looking at the Jira and the review, there is no indicaiton as to what use cases this api addition addresses.  We only know that a 'stack_versions' endpoint is being added as a subresource of clustsers and hosts and we know the fields available in the endpoint but not how it is to be used and why it is needed. The -1 was not because I think that there is an issue with this work, but instead because there is no way to know if this api is appropriate since it is impossible to know what it is supposed to do.  In my opinion, no sigificant api changes should ever be merged without documentaiton and/or a design document that at a minimum descibes the driving use case and provides examples of the api. For this Jira, all we have is examples of the api.  With this information it is only possible to review the implementation, not the api.  API changes are a significant
  commitment that last well into the future and must be held to a higher standard that an implementation because we can't just change the api. 

I am happy that this has gone through significant design, all that I ask is that those design docs be attached to the Jira so that it is possible to provide a meaningful review of the api changes.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61787
-----------------------------------------------------------


On Nov. 17, 2014, 6:28 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 6:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Nate Cole <nc...@hortonworks.com>.


> On Nov. 17, 2014, 3:08 p.m., John Speidel wrote:
> > -1
> > Please dion't merge this.
> > 
> > Please point to a design document for this api addition or documentation that describes the details of this api and why it is needed.
> > Most of this information is already available via the api.
> > 
> > Also, please include Tom Beerbower in all API related reviews.

John, no this is something different.  This effort is to support rolling upgrades of a cluster, where we have to maintain version information for a cluster.  In addition, we are also going to be tracking which versions have been installed on hosts.  This is a major feature of 2.0.0 and has already been through significant design.  Having said that, I've made comments to see if this patch can be simplified a bit.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61787
-----------------------------------------------------------


On Nov. 17, 2014, 1:28 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 1:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by John Speidel <js...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61787
-----------------------------------------------------------


-1
Please dion't merge this.

Please point to a design document for this api addition or documentation that describes the details of this api and why it is needed.
Most of this information is already available via the api.

Also, please include Tom Beerbower in all API related reviews.

- John Speidel


On Nov. 17, 2014, 6:28 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 6:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Tom Beerbower <tb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61911
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java
<https://reviews.apache.org/r/28124/#comment103834>

    Since this class is nearly identical to ClusterStackVersionResourceDefinition, would it make sense to have an abstract StackVersionResourceDefinition that they both extend?  ... or just have a StackVersionResourceDefinition that takes a Resource.Type in the constructor?



ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java
<https://reviews.apache.org/r/28124/#comment103836>

    Again, not sure if it makes sense but could the common code with ClusterStackVersionService be factored out here?  Seems like the only real differences are the mapIds types.



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java
<https://reviews.apache.org/r/28124/#comment103837>

    Is this annotation really needed?


- Tom Beerbower


On Nov. 18, 2014, 12:36 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 12:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review62350
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Nov. 20, 2014, 2:04 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 2:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 8f10143 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 1442a0c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 3cd54f5 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> Total run:672
> Total errors:0
> Total failures:0
> OK
> 
> 
> Results :
> 
> Tests run: 2272, Failures: 0, Errors: 0, Skipped: 14
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Yurii Shylov <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/
-----------------------------------------------------------

(Updated Ноя. 20, 2014, 2:04 п.п.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.


Changes
-------

Merge with latest trunk


Bugs: AMBARI-8353
    https://issues.apache.org/jira/browse/AMBARI-8353


Repository: ambari


Description
-------

Add stack_versions subresource to /hosts and /clusters 


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 8f10143 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 1442a0c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
  ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
  ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 3cd54f5 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 

Diff: https://reviews.apache.org/r/28124/diff/


Testing
-------

Total run:672
Total errors:0
Total failures:0
OK


Results :

Tests run: 2272, Failures: 0, Errors: 0, Skipped: 14


Thanks,

Yurii Shylov

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review62339
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Nov. 20, 2014, 10:54 a.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 10:54 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 8f10143 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 1442a0c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> Total run:672
> Total errors:0
> Total failures:0
> OK
> 
> 
> Results :
> 
> Tests run: 2272, Failures: 0, Errors: 0, Skipped: 14
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Tom Beerbower <tb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review62345
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On Nov. 20, 2014, 10:54 a.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 10:54 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 8f10143 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 1442a0c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> Total run:672
> Total errors:0
> Total failures:0
> OK
> 
> 
> Results :
> 
> Tests run: 2272, Failures: 0, Errors: 0, Skipped: 14
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Yurii Shylov <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/
-----------------------------------------------------------

(Updated Ноя. 20, 2014, 10:54 д.п.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.


Bugs: AMBARI-8353
    https://issues.apache.org/jira/browse/AMBARI-8353


Repository: ambari


Description
-------

Add stack_versions subresource to /hosts and /clusters 


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 8f10143 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 1442a0c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
  ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
  ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 

Diff: https://reviews.apache.org/r/28124/diff/


Testing (updated)
-------

Total run:672
Total errors:0
Total failures:0
OK


Results :

Tests run: 2272, Failures: 0, Errors: 0, Skipped: 14


Thanks,

Yurii Shylov

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Yurii Shylov <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/
-----------------------------------------------------------

(Updated Ноя. 20, 2014, 10:52 д.п.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.


Changes
-------

Removed unnecessary @StaticallyInject


Bugs: AMBARI-8353
    https://issues.apache.org/jira/browse/AMBARI-8353


Repository: ambari


Description
-------

Add stack_versions subresource to /hosts and /clusters 


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 8f10143 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 1442a0c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
  ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
  ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 

Diff: https://reviews.apache.org/r/28124/diff/


Testing
-------

in progress


Thanks,

Yurii Shylov

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review62330
-----------------------------------------------------------

Ship it!


I think this looks pretty good overall.  One minor nit that can be addressed later.  Please wait for comments, especially from Tom or John before it gets pushed.


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java
<https://reviews.apache.org/r/28124/#comment104361>

    I actually don't see anything injected here, so no need for this (a resource provider is explicitly constructed)


- Nate Cole


On Nov. 19, 2014, 12:41 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2014, 12:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 8f10143 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 1442a0c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Yurii Shylov <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/
-----------------------------------------------------------

(Updated Ноя. 19, 2014, 5:41 п.п.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.


Changes
-------

Changed according to reviews. Though I've left ResourceProviders and Services separate, see my comments above


Bugs: AMBARI-8353
    https://issues.apache.org/jira/browse/AMBARI-8353


Repository: ambari


Description
-------

Add stack_versions subresource to /hosts and /clusters 


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 8f10143 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 1442a0c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
  ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
  ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 

Diff: https://reviews.apache.org/r/28124/diff/


Testing
-------

in progress


Thanks,

Yurii Shylov

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Yurii Shylov <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/
-----------------------------------------------------------

(Updated Ноя. 18, 2014, 12:36 п.п.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.


Bugs: AMBARI-8353
    https://issues.apache.org/jira/browse/AMBARI-8353


Repository: ambari


Description
-------

Add stack_versions subresource to /hosts and /clusters 


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
  ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
  ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 

Diff: https://reviews.apache.org/r/28124/diff/


Testing
-------

in progress


Thanks,

Yurii Shylov

Re: Review Request 28124: Repository Version Management - Create subresource for hosts and clusters

Posted by Alejandro Fernandez <af...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28124/#review61800
-----------------------------------------------------------

Ship it!


LGTM, wait for one more +1 and comments from Tom

- Alejandro Fernandez


On Nov. 17, 2014, 6:28 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28124/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 6:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8353
>     https://issues.apache.org/jira/browse/AMBARI-8353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add stack_versions subresource to /hosts and /clusters 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java ef907c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java 14ed799 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 9ad37ec 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f75ae11 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c51722c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 2d91462 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java 212f944 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c198dd6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java dbac906 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java e2a2e2d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 8d147a1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java aaf8eed 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 5b1b4f8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java 72cd541 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java 7296e8d 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java c0e625a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java e8ce2f7 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java 42bf009 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java 93f78b2 
> 
> Diff: https://reviews.apache.org/r/28124/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>