You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2018/08/27 01:56:32 UTC
[GitHub] zeppelin pull request #3164: [MINOR] Add `fmt:check` to check style
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/3164
[MINOR] Add `fmt:check` to check style
### What is this PR for?
Adding a new simple travis profile to check style only
### What type of PR is it?
[Improvement]
### Todos
* [x] - Add a new profile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin minor/add-fmt-check
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3164.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3164
----
commit 55f6c91cab2149943fd2390e0a9ca6847ac1f6ce
Author: Jongyoul Lee <jo...@...>
Date: 2018-08-21T08:45:04Z
[ZEPPELIN-3740] Adopt `google-java-format` and `fmt-maven-plugin`
### What is this PR for?
Avoiding outdated checkstyle error.
To check format
`mvn validate`
To fix non-complying files
`mvn fmt:format`
### What type of PR is it?
[Improvement | Refactoring]
### Todos
* [x] - Adopt `fmt-maven-plugin`
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3740
### How should this be tested?
CI passs
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes for contributors
Author: Jongyoul Lee <jo...@gmail.com>
Closes #3158 from jongyoul/ZEPPELIN-3740 and squashes the following commits:
f06c50e90 [Jongyoul Lee] Adopt `fmt-maven-plugin` for google-java-format Adopt all files
commit 8a42c5428b21640354b09fabf0aa6883772035e1
Author: Jongyoul Lee <jo...@...>
Date: 2018-08-27T01:29:41Z
Add a profile for checking style in travis
Fix non-complying files of `R` profile
commit 31525037b5ee7a53ee828e9b8b7a8b58ea5d9ee4
Author: Jongyoul Lee <jo...@...>
Date: 2018-08-27T01:52:44Z
Add snapshot repository for travis
----
---
[GitHub] zeppelin issue #3164: [MINOR] Add `fmt:check` to check style
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3164
New travis profile has been passed. https://travis-ci.org/jongyoul/zeppelin/builds/421893674 Will merge it
---
[GitHub] zeppelin pull request #3164: [MINOR] Add `fmt:check` to check style
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3164
---