You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/04/21 11:41:12 UTC
[GitHub] [hive] ganeshashree opened a new pull request, #3231: HIVE-22013: SHOW TABLE EXTENDED query fails with Wrong FS error for partition in customized location
ganeshashree opened a new pull request, #3231:
URL: https://github.com/apache/hive/pull/3231
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Fix is done by using a right file system when partition is in different location than table's path .
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To fix a bug where `SHOW TABLE EXTENDED` query fails with `Wrong FS` error for a partition in a different file system or a different bucket in S3.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behaviour difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added qtest for a case where partition is not in table's path. Also, tested manually for cases like 1) partition and table are in different S3 bucket 2) Table is in HDFS and partition is in S3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn commented on a diff in pull request #3231: HIVE-22013: SHOW TABLE EXTENDED query fails with Wrong FS error for partition in customized location
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on code in PR #3231:
URL: https://github.com/apache/hive/pull/3231#discussion_r864755215
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/status/formatter/ShowTableStatusFormatter.java:
##########
@@ -123,13 +123,17 @@ FileData getFileData(HiveConf conf, List<Path> locations, Path tablePath) throws
if (!fileData.unknown) {
for (Path location : locations) {
try {
- FileStatus status = fileSystem.getFileStatus(location);
+ // Use right FileSystem object for partition in customized location
+ FileSystem locationFileSystem = location.toString().startsWith(tablePath.toString()) ? fileSystem
+ : location.getFileSystem(conf);
Review Comment:
if the partition location is hdfs://ns1/tmp/hivePart and the table location is hdfs://ns1/hive/table
In this case the FileSystem is same, still you will land up doing this getFileSystem()? We could have matched the scheme & authority of the path only?
Secondly, if we want to do this only, can we use `FileUtils.isPathWithinSubtree(location, tablePath)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ganeshashree commented on pull request #3231: HIVE-22013: SHOW TABLE EXTENDED query fails with Wrong FS error for partition in customized location
Posted by GitBox <gi...@apache.org>.
ganeshashree commented on PR #3231:
URL: https://github.com/apache/hive/pull/3231#issuecomment-1114473524
@miklosgergely Thanks for reviewing. Please help with merging this fix to master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #3231: HIVE-22013: SHOW TABLE EXTENDED query fails with Wrong FS error for partition in customized location
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3231:
URL: https://github.com/apache/hive/pull/3231#issuecomment-1247430251
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ganeshashree commented on a diff in pull request #3231: HIVE-22013: SHOW TABLE EXTENDED query fails with Wrong FS error for partition in customized location
Posted by GitBox <gi...@apache.org>.
ganeshashree commented on code in PR #3231:
URL: https://github.com/apache/hive/pull/3231#discussion_r873194842
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/status/formatter/ShowTableStatusFormatter.java:
##########
@@ -123,13 +123,17 @@ FileData getFileData(HiveConf conf, List<Path> locations, Path tablePath) throws
if (!fileData.unknown) {
for (Path location : locations) {
try {
- FileStatus status = fileSystem.getFileStatus(location);
+ // Use right FileSystem object for partition in customized location
+ FileSystem locationFileSystem = location.toString().startsWith(tablePath.toString()) ? fileSystem
+ : location.getFileSystem(conf);
Review Comment:
@ayushtkn Thanks for reviewing. It makes sense to match scheme and authority. Please review the updated PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ganeshashree commented on pull request #3231: HIVE-22013: SHOW TABLE EXTENDED query fails with Wrong FS error for partition in customized location
Posted by GitBox <gi...@apache.org>.
ganeshashree commented on PR #3231:
URL: https://github.com/apache/hive/pull/3231#issuecomment-1186184895
@ayushtkn Please review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #3231: HIVE-22013: SHOW TABLE EXTENDED query fails with Wrong FS error for partition in customized location
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3231: HIVE-22013: SHOW TABLE EXTENDED query fails with Wrong FS error for partition in customized location
URL: https://github.com/apache/hive/pull/3231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org