[jira] [Commented] (FLINK-9410) Replace NMClient with NMClientAsync in YarnResourceManager

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500149#comment-16500149 ] 

ASF GitHub Bot commented on FLINK-9410:
---------------------------------------

Github user sihuazhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6087#discussion_r192723013
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -356,7 +363,8 @@ public void onContainersAllocated(List<Container> containers) {
     
     					final String containerIdStr = container.getId().toString();
     					final ResourceID resourceId = new ResourceID(containerIdStr);
    -
    +					this.resourceId = resourceId;
    +					this.container = container;
    --- End diff --
    
    I think we can't do it like this, the `resourceId` will be reset by another request... as well as the `contianer`


> Replace NMClient with NMClientAsync in YarnResourceManager
> ----------------------------------------------------------
>
>                 Key: FLINK-9410
>                 URL: https://issues.apache.org/jira/browse/FLINK-9410
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: mingleizhang
>            Priority: Critical
>             Fix For: 1.6.0
>
>
> Currently, the {{YarnResourceManager}} uses the synchronous {{NMClient}} which is called from within the main thread of the {{ResourceManager}}. Since these operations are blocking, we should replace the client with the {{NMClientAsync}} and make the calls non blocking.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)