[GitHub] [incubator-pinot] snleee commented on a change in pull request #4735: Changing error log to warn in SegmentPreprocessingMapper

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #4735: Changing error log to warn in SegmentPreprocessingMapper
URL: https://github.com/apache/incubator-pinot/pull/4735#discussion_r337661483
 
 

 ##########
 File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mappers/SegmentPreprocessingMapper.java
 ##########
 @@ -94,7 +94,7 @@ public void map(AvroKey<GenericRecord> record, NullWritable value, final Context
       if (!normalizedTimeColumnValue.equals(_sampleNormalizedTimeColumnValue)) {
         // TODO: Create a custom exception and gracefully catch this exception outside, changing what the path to input
         // into segment creation should be
-        LOGGER.error("This segment contains multiple time units. Sample is {}, current is {}", _sampleNormalizedTimeColumnValue, normalizedTimeColumnValue);
+        LOGGER.warn("This segment contains multiple time units. Sample is {}, current is {}", _sampleNormalizedTimeColumnValue, normalizedTimeColumnValue);
 
 Review comment:
   We should avoid to put record level log unless it would really provide the good information. Even if changing the log level to `WARN` won't log to Travis, this will be logged to other jobs (actual hadoop job, TMC test..etc).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org