You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "vinoyang (JIRA)" <ji...@apache.org> on 2018/12/08 02:38:00 UTC

[jira] [Assigned] (FLINK-11102) Enable check for previous data in SpanningRecordSerializer

     [ https://issues.apache.org/jira/browse/FLINK-11102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

vinoyang reassigned FLINK-11102:
--------------------------------

    Assignee: vinoyang

> Enable check for previous data in SpanningRecordSerializer
> ----------------------------------------------------------
>
>                 Key: FLINK-11102
>                 URL: https://issues.apache.org/jira/browse/FLINK-11102
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>    Affects Versions: 1.8.0
>            Reporter: Nico Kruber
>            Assignee: vinoyang
>            Priority: Major
>
> {{SpanningRecordSerializer}} only verifies that there is no left-over data from a previous serialization call if {{SpanningRecordSerializer#CHECKED}} is {{true}} but this is hard-coded as {{false}}. Now if there was previous data, we would silently drop this and continue with our data. The deserializer would probably notice and fail but identifying the root cause may not be as easy anymore.
> -> We should enable that check by default since the only thing it does is to verify {{!java.nio.Buffer#hasRemaining()}} which cannot be too expensive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)