You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ashishkumar50 (via GitHub)" <gi...@apache.org> on 2026/05/04 04:30:29 UTC

Re: [PR] HDDS-14942. Implement manifest selection logic for rewrite based on snapshot delta [ozone]

ashishkumar50 commented on code in PR #10145:
URL: https://github.com/apache/ozone/pull/10145#discussion_r3179397089


##########
hadoop-ozone/iceberg/src/main/java/org/apache/hadoop/ozone/iceberg/RewriteTablePathOzoneAction.java:
##########
@@ -251,4 +271,109 @@ private Set<Pair<String, String>> rewriteVersionFile(TableMetadata metadata, Str
 
     return result;
   }
+
+  private Set<String> manifestsToRewrite(Set<Snapshot> deltaSnapshots, TableMetadata startMetadata) {
+    Table endStaticTable = RewriteTablePathOzoneUtils.newStaticTable(endVersionName, table.io());
+
+    final Set<Long> deltaSnapshotIds;
+    if (startMetadata != null) {

Review Comment:
   In that case `manifestsToRewrite` you can populate outside the caller and avoid passing startMetadata here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org