[GitHub] [arrow] westonpace commented on pull request #10255: ARROW-12661: [C++] Add ReaderOptions::skip_rows_after_names

[GitBox <gi...@apache.org>]

westonpace commented on pull request #10255:
URL: https://github.com/apache/arrow/pull/10255#issuecomment-833115352


   Thanks for submitting these PRs!  I'm still brushing up on my parser knowledge but I'll take a look at the other one too.
   
   This one looks pretty straightforward to me.  It's a bit unfortunate that we have two `skip_rows` but it does seem that there are cases for skipping before and after.  I do prefer this over the before/after boolean.  Another option would be to take in a list of row indices.  This is what pandas does.  So [0:1] skips two rows before the header (if any) and [1:2] would skip two rows after the header or [0, 2] would skip a row before and after.
   
   @pitrou should probably take a look at this as he's got the most experience with the CSV reader.  He's out for the rest of the week so it might be next week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org