You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/06/27 21:39:47 UTC

[jira] [Created] (HADOOP-7428) IPC connection is orphaned with null 'out' member

IPC connection is orphaned with null 'out' member
-------------------------------------------------

                 Key: HADOOP-7428
                 URL: https://issues.apache.org/jira/browse/HADOOP-7428
             Project: Hadoop Common
          Issue Type: Bug
          Components: ipc
    Affects Versions: 0.23.0
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon


We had a situation a JT ended up in a state where a certain user could not submit a job, due to an NPE on the following line in {{sendParam}}:
{code}
synchronized (Connection.this.out) {
{code}
Looking at the code, my guess is that an RTE was thrown in setupIOstreams, which only catches IOE. This could leave the connection in a half-setup state which is never cleaned up and also cannot perform IPCs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7428) IPC connection is orphaned with null 'out' member

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057957#comment-13057957 ] 

Eli Collins commented on HADOOP-7428:
-------------------------------------

+1  good catch.

> IPC connection is orphaned with null 'out' member
> -------------------------------------------------
>
>                 Key: HADOOP-7428
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7428
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-7428.txt
>
>
> We had a situation a JT ended up in a state where a certain user could not submit a job, due to an NPE on the following line in {{sendParam}}:
> {code}
> synchronized (Connection.this.out) {
> {code}
> Looking at the code, my guess is that an RTE was thrown in setupIOstreams, which only catches IOE. This could leave the connection in a half-setup state which is never cleaned up and also cannot perform IPCs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7428) IPC connection is orphaned with null 'out' member

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058482#comment-13058482 ] 

Hudson commented on HADOOP-7428:
--------------------------------

Integrated in Hadoop-Common-trunk #734 (See [https://builds.apache.org/job/Hadoop-Common-trunk/734/])
    HADOOP-7428. IPC connection is orphaned with null 'out' member. Contributed by Todd Lipcon

eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141638
Files : 
* /hadoop/common/trunk/common/CHANGES.txt
* /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/ipc/TestIPC.java
* /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java


> IPC connection is orphaned with null 'out' member
> -------------------------------------------------
>
>                 Key: HADOOP-7428
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7428
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-7428.txt
>
>
> We had a situation a JT ended up in a state where a certain user could not submit a job, due to an NPE on the following line in {{sendParam}}:
> {code}
> synchronized (Connection.this.out) {
> {code}
> Looking at the code, my guess is that an RTE was thrown in setupIOstreams, which only catches IOE. This could leave the connection in a half-setup state which is never cleaned up and also cannot perform IPCs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7428) IPC connection is orphaned with null 'out' member

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HADOOP-7428:
--------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I've committed this. Thanks Todd!

> IPC connection is orphaned with null 'out' member
> -------------------------------------------------
>
>                 Key: HADOOP-7428
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7428
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-7428.txt
>
>
> We had a situation a JT ended up in a state where a certain user could not submit a job, due to an NPE on the following line in {{sendParam}}:
> {code}
> synchronized (Connection.this.out) {
> {code}
> Looking at the code, my guess is that an RTE was thrown in setupIOstreams, which only catches IOE. This could leave the connection in a half-setup state which is never cleaned up and also cannot perform IPCs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7428) IPC connection is orphaned with null 'out' member

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-7428:
----------------------------

    Fix Version/s: 0.23.0

> IPC connection is orphaned with null 'out' member
> -------------------------------------------------
>
>                 Key: HADOOP-7428
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7428
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7428.txt
>
>
> We had a situation a JT ended up in a state where a certain user could not submit a job, due to an NPE on the following line in {{sendParam}}:
> {code}
> synchronized (Connection.this.out) {
> {code}
> Looking at the code, my guess is that an RTE was thrown in setupIOstreams, which only catches IOE. This could leave the connection in a half-setup state which is never cleaned up and also cannot perform IPCs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7428) IPC connection is orphaned with null 'out' member

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056670#comment-13056670 ] 

Hadoop QA commented on HADOOP-7428:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12484478/hadoop-7428.txt
  against trunk revision 1140442.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/681//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/681//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/681//console

This message is automatically generated.

> IPC connection is orphaned with null 'out' member
> -------------------------------------------------
>
>                 Key: HADOOP-7428
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7428
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-7428.txt
>
>
> We had a situation a JT ended up in a state where a certain user could not submit a job, due to an NPE on the following line in {{sendParam}}:
> {code}
> synchronized (Connection.this.out) {
> {code}
> Looking at the code, my guess is that an RTE was thrown in setupIOstreams, which only catches IOE. This could leave the connection in a half-setup state which is never cleaned up and also cannot perform IPCs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7428) IPC connection is orphaned with null 'out' member

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057964#comment-13057964 ] 

Hudson commented on HADOOP-7428:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #669 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/669/])
    HADOOP-7428. IPC connection is orphaned with null 'out' member. Contributed by Todd Lipcon

eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141638
Files : 
* /hadoop/common/trunk/common/CHANGES.txt
* /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/ipc/TestIPC.java
* /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java


> IPC connection is orphaned with null 'out' member
> -------------------------------------------------
>
>                 Key: HADOOP-7428
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7428
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-7428.txt
>
>
> We had a situation a JT ended up in a state where a certain user could not submit a job, due to an NPE on the following line in {{sendParam}}:
> {code}
> synchronized (Connection.this.out) {
> {code}
> Looking at the code, my guess is that an RTE was thrown in setupIOstreams, which only catches IOE. This could leave the connection in a half-setup state which is never cleaned up and also cannot perform IPCs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7428) IPC connection is orphaned with null 'out' member

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-7428:
--------------------------------

    Status: Patch Available  (was: Open)

> IPC connection is orphaned with null 'out' member
> -------------------------------------------------
>
>                 Key: HADOOP-7428
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7428
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-7428.txt
>
>
> We had a situation a JT ended up in a state where a certain user could not submit a job, due to an NPE on the following line in {{sendParam}}:
> {code}
> synchronized (Connection.this.out) {
> {code}
> Looking at the code, my guess is that an RTE was thrown in setupIOstreams, which only catches IOE. This could leave the connection in a half-setup state which is never cleaned up and also cannot perform IPCs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7428) IPC connection is orphaned with null 'out' member

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-7428:
--------------------------------

    Attachment: hadoop-7428.txt

Here's a patch which demonstrates the issue. The unit test is a little bit contrived, but does demonstrate the issue and act as a regression test.

> IPC connection is orphaned with null 'out' member
> -------------------------------------------------
>
>                 Key: HADOOP-7428
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7428
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-7428.txt
>
>
> We had a situation a JT ended up in a state where a certain user could not submit a job, due to an NPE on the following line in {{sendParam}}:
> {code}
> synchronized (Connection.this.out) {
> {code}
> Looking at the code, my guess is that an RTE was thrown in setupIOstreams, which only catches IOE. This could leave the connection in a half-setup state which is never cleaned up and also cannot perform IPCs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7428) IPC connection is orphaned with null 'out' member

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058266#comment-13058266 ] 

Hudson commented on HADOOP-7428:
--------------------------------

Integrated in Hadoop-Common-trunk-maven #45 (See [https://builds.apache.org/job/Hadoop-Common-trunk-maven/45/])
    HADOOP-7428. IPC connection is orphaned with null 'out' member. Contributed by Todd Lipcon

eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141638
Files : 
* /hadoop/common/trunk/common/CHANGES.txt
* /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/ipc/TestIPC.java
* /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java


> IPC connection is orphaned with null 'out' member
> -------------------------------------------------
>
>                 Key: HADOOP-7428
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7428
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-7428.txt
>
>
> We had a situation a JT ended up in a state where a certain user could not submit a job, due to an NPE on the following line in {{sendParam}}:
> {code}
> synchronized (Connection.this.out) {
> {code}
> Looking at the code, my guess is that an RTE was thrown in setupIOstreams, which only catches IOE. This could leave the connection in a half-setup state which is never cleaned up and also cannot perform IPCs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira