You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/15 00:28:18 UTC
[GitHub] [superset] rosemarie-chiu opened a new issue #15698: [Dataset edit modal] UX for edit metrics tab need improvement
rosemarie-chiu opened a new issue #15698:
URL: https://github.com/apache/superset/issues/15698
**Is your feature request related to a problem? Please describe.**
It is confusing how to edit metrics in edit dataset modal.
1. I can only add SQL expression in the list, and I cannot see it after I expand an item? not when I expand it?
2. I can only add label after I expand it? It is unclear to user that they need to expand the item to add label vs can update sql expression right from the list
3. Once added a label, can edit it on either list or expanded form, but they are not synced?
**Describe the solution you'd like**
1. I think if we want to expand an item into form and have more input fields, we should be consistent that sql expression field, label field all present in the expand form.
2. Should be consistent on either able to edit every fields in list view
3. Should not be able to update data in list when the form is expanded (problem 3)
**Describe alternatives you've considered**
Alternatively, make it not able to edit any fields in list view at all, do all modification in the expand form.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #15698: [Dataset edit modal] UX for edit metrics tab need improvement
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #15698:
URL: https://github.com/apache/superset/issues/15698#issuecomment-880597174
@rosemarie-chiu Totally agree with your points. I would like to add that we should consider Metrics, Columns, and Calculated Columns when deciding the behavior because they all look the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on issue #15698: [Dataset edit modal] UX for edit metrics tab need improvement
Posted by GitBox <gi...@apache.org>.
srinify commented on issue #15698:
URL: https://github.com/apache/superset/issues/15698#issuecomment-1069333688
Converting to Discussion since it's a feature request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15698: [Dataset edit modal] UX for edit metrics tab need improvement
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15698:
URL: https://github.com/apache/superset/issues/15698#issuecomment-880299403
let's discuss a middle ground solution and tackle it by mid Aug. @michael-s-molina 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org