You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/08/05 12:08:17 UTC

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1317: nimble/ll: Use OTA max rx time for connection event calculations

andrzej-kaczmarek opened a new pull request, #1317:
URL: https://github.com/apache/mynewt-nimble/pull/1317

   Using effective max rx time for connection event calculations is not
   optimal since it's possible that time to rx packet with max octets
   payload is shorter that effective max rx time. Instead, we should
   calculate time it takes to rx packaet with effectiva max octets payload
   and use it if less than effective max rx time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1317: nimble/ll: Use OTA max rx time for connection event calculations

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1317:
URL: https://github.com/apache/mynewt-nimble/pull/1317#issuecomment-1206381588

   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### nimble/controller/src/ble_ll_conn.c
   <details>
   
   ```diff
   @@ -1260,8 +1259,8 @@
    #endif
    
            ticks = (BLE_LL_IFS * 3) + connsm->ota_max_rx_time +
   -            ble_ll_pdu_tx_time_get(next_txlen, tx_phy_mode) +
   -            ble_ll_pdu_tx_time_get(cur_txlen, tx_phy_mode);
   +                ble_ll_pdu_tx_time_get(next_txlen, tx_phy_mode) +
   +                ble_ll_pdu_tx_time_get(cur_txlen, tx_phy_mode);
    
    #if MYNEWT_VAL(BLE_LL_ROLE_CENTRAL)
            if (connsm->conn_role == BLE_LL_CONN_ROLE_CENTRAL) {
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1317: nimble/ll: Use OTA max rx time for connection event calculations

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek merged PR #1317:
URL: https://github.com/apache/mynewt-nimble/pull/1317


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org