You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/13 13:51:57 UTC
[GitHub] [incubator-druid] Fokko commented on a change in pull request
#8006: Bump commons-io from 2.5 to 2.6
Fokko commented on a change in pull request #8006: Bump commons-io from 2.5 to 2.6
URL: https://github.com/apache/incubator-druid/pull/8006#discussion_r313407816
##########
File path: server/src/main/java/org/apache/druid/segment/realtime/plumber/Plumbers.java
##########
@@ -51,9 +53,9 @@ public static void addNextRow(
try {
inputRow = firehose.nextRow();
}
- catch (ParseException e) {
- if (reportParseExceptions) {
- throw e;
+ catch (ParseException | IOException e) {
Review comment:
Ack, updated the PR. Much better indeed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org