You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2013/11/23 02:45:15 UTC
Review Request 15817: [HELIX-321] Controller forgets that it's the leader
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15817/
-----------------------------------------------------------
Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
Bugs: HELIX-321
Repository: helix-git
Description
-------
commit b0051145fcb0f8d31dac67509aa971b85811f470
Author: Kanak Biscuitwala <ka...@apache.org>
Date: Fri Nov 22 17:42:13 2013 -0800
[HELIX-321] Controller forgets that it's the leader
:100644 100644 ecafbc8... e52427c... M helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java ecafbc8
Diff: https://reviews.apache.org/r/15817/diff/
Testing
-------
Ran test framework with a controller process that uses HelixConnection. It fails every time before the fix and passes every time after.
Thanks,
Kanak Biscuitwala
Re: Review Request 15817: [HELIX-321] Controller forgets that it's the leader
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15817/#review29333
-----------------------------------------------------------
Ship it!
Ship It!
- Kishore Gopalakrishna
On Nov. 23, 2013, 1:45 a.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15817/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2013, 1:45 a.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-321
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit b0051145fcb0f8d31dac67509aa971b85811f470
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Fri Nov 22 17:42:13 2013 -0800
>
> [HELIX-321] Controller forgets that it's the leader
>
> :100644 100644 ecafbc8... e52427c... M helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java ecafbc8
>
> Diff: https://reviews.apache.org/r/15817/diff/
>
>
> Testing
> -------
>
> Ran test framework with a controller process that uses HelixConnection. It fails every time before the fix and passes every time after.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>