[GitHub] [hadoop] slfan1989 commented on a diff in pull request #6068: YARN-11566. Yarn app kill command can not kill the application in sec…

["slfan1989 (via GitHub)" <gi...@apache.org>]

slfan1989 commented on code in PR #6068:
URL: https://github.com/apache/hadoop/pull/6068#discussion_r1325818204


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/FederationInterceptor.java:
##########
@@ -897,9 +897,16 @@ public void setNextInterceptor(RequestInterceptor next) {
    * release all the resources that we are holding in this call.
    */
   @Override
-  public void shutdown() {
+  public void shutdown(boolean stop) {

Review Comment:
   YARN-6848 plans to unify the Interceptor interface. Can we not change the shutdown parameters? Are there any other ways we can solve the issue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org