[jira] [Commented] (PARQUET-871) [C++] Mechanism to avoid passing -Werror to thirdparty libraries

["Uwe L. Korn (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859224#comment-15859224 ] 

Uwe L. Korn commented on PARQUET-871:
-------------------------------------

Two possible solutions:

 * We introduce a second CMAKE_PARQUET_CXX_FLAGS that is only given to {{parquet-cpp}} sources.
 * We blacklist various options that shouldn't be passed to third-party components, e.g {{-Werror}}

The passing of CXXFLAGS to the thirdparty sources is essential for debugging and release flag purposes. Also I need this for the clang-sanitizers.

> [C++] Mechanism to avoid passing -Werror to thirdparty libraries
> ----------------------------------------------------------------
>
>                 Key: PARQUET-871
>                 URL: https://issues.apache.org/jira/browse/PARQUET-871
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>
> [~xhochy] I noticed after PARQUET-865 that my builds fail because I pass {{-Werror}} in {{$CXXFLAGS}}. I have
> {code}
> export CXXFLAGS="-Werror -Wall -fno-omit-frame-pointer"
> {code}
> How do we pass compiler flags to parquet-cpp only and not also the thirdparty libraries?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)