You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/07 09:34:28 UTC
[GitHub] [superset] xneg opened a new issue #15011: Determination of the select queries in BaseEngineSpec
xneg opened a new issue #15011:
URL: https://github.com/apache/superset/issues/15011
Hello!
We are now developing a new SQLAlchemy dialect for Kusto (Azure Data Explorer) and want add support for Kusto database in Superset in nearly future. (This also covers https://github.com/apache/superset/issues/10646.)
Kusto language has two dialects: SQL and KQL. While there is no problem with SQL dialect, we also want to integrate KQL in Superset.
**Problem**
KQL select queries do not contain the word "SELECT" so they look like
`MyTable | take 10` (this is equivalent of `Select * from MyTable Limit 10`).
The absence of the "SELECT" keyword breaks the limit behavior in SQLLab because it relies on the `sqlparse` package and we can't add a limit to queries from UI.
**Proposed solution**
The solution is to make the determination of the select queries in BaseEngineSpec so that you can override it in your own spec. This is the same way how base dialect determines read-only queries with `is_readonly_query`.
We will provide PR to implement this small feature.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xneg commented on issue #15011: Determination of the select queries in BaseEngineSpec
Posted by GitBox <gi...@apache.org>.
xneg commented on issue #15011:
URL: https://github.com/apache/superset/issues/15011#issuecomment-856512452
Closed by https://github.com/apache/superset/pull/15013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xneg closed issue #15011: Determination of the select queries in BaseEngineSpec
Posted by GitBox <gi...@apache.org>.
xneg closed issue #15011:
URL: https://github.com/apache/superset/issues/15011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org