You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/04/26 04:21:52 UTC
[GitHub] [tomcat] XavierChengZW opened a new pull request #286: optimized code,replace some c-style array
XavierChengZW opened a new pull request #286:
URL: https://github.com/apache/tomcat/pull/286
optimized code,replace some c-style array Brackets are a part of an Array type. The definition could be: String[] args
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #286: optimized code,replace some c-style array
Posted by GitBox <gi...@apache.org>.
rmaucher commented on pull request #286:
URL: https://github.com/apache/tomcat/pull/286#issuecomment-619853801
Hmmm :(
So, ok, I guess you have to start somewhere, but it is best to have PRs on something meaningful (like at least a small bugfix or real improvement of some sort). Here, maybe at least do the change to the entire codebase instead of a single class.
Also the change then usually needs to be cherry picked to all current branches.
Overall this sort of PR creates a ton of noise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on pull request #286: optimized code,replace some c-style array
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #286:
URL: https://github.com/apache/tomcat/pull/286#issuecomment-619872274
Thanks for cherry-picking the change, Remy! I was interrupted after merging the PR and I was going to do it at lunch break.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on pull request #286: optimized code,replace some c-style array
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #286:
URL: https://github.com/apache/tomcat/pull/286#issuecomment-619781821
Thank you, @XavierChengZW !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org