You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "HHoflittlefish777 (via GitHub)" <gi...@apache.org> on 2023/07/27 11:19:07 UTC
[GitHub] [skywalking-banyandb] HHoflittlefish777 opened a new pull request, #306: Define file system operation interface
HHoflittlefish777 opened a new pull request, #306:
URL: https://github.com/apache/skywalking-banyandb/pull/306
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #306: Define file system operation interface
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on code in PR #306:
URL: https://github.com/apache/skywalking-banyandb/pull/306#discussion_r1280623327
##########
dist/LICENSE:
##########
@@ -456,6 +456,7 @@ MIT licenses
fill-range 7.0.1 MIT
follow-redirects 1.15.2 MIT
form-data 4.0.0 MIT
+ fsevents 2.3.2 MIT
Review Comment:
After updating the check CI task, `fsevent` should not be here. Refer to https://github.com/apache/skywalking-banyandb/actions/runs/5725004262/job/15512612364?pr=306#step:13:78
You can follow the steps defined at https://github.com/apache/skywalking-banyandb/blob/main/.github/workflows/ci.yml#L32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #306: Define file system operation interface
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on code in PR #306:
URL: https://github.com/apache/skywalking-banyandb/pull/306#discussion_r1278802047
##########
dist/LICENSE:
##########
@@ -456,6 +456,7 @@ MIT licenses
fill-range 7.0.1 MIT
follow-redirects 1.15.2 MIT
form-data 4.0.0 MIT
+ fsevents 2.3.2 MIT
Review Comment:
Where is it from? You've not introduced it in `go.mod` yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] HHoflittlefish777 commented on a diff in pull request #306: Define file system operation interface
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on code in PR #306:
URL: https://github.com/apache/skywalking-banyandb/pull/306#discussion_r1280058293
##########
dist/LICENSE:
##########
@@ -456,6 +456,7 @@ MIT licenses
fill-range 7.0.1 MIT
follow-redirects 1.15.2 MIT
form-data 4.0.0 MIT
+ fsevents 2.3.2 MIT
Review Comment:
The result of removing and rerunning make license-dep is the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #306: Define file system operation interface
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on code in PR #306:
URL: https://github.com/apache/skywalking-banyandb/pull/306#discussion_r1279470936
##########
dist/LICENSE:
##########
@@ -456,6 +456,7 @@ MIT licenses
fill-range 7.0.1 MIT
follow-redirects 1.15.2 MIT
form-data 4.0.0 MIT
+ fsevents 2.3.2 MIT
Review Comment:
Please remove your local `<banyandb_root_dir>/bin`. And rerun this command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #306: Define file system operation interface
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #306:
URL: https://github.com/apache/skywalking-banyandb/pull/306#issuecomment-1654948478
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/306?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#306](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/306?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b381f03) into [main](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/42c10e617b9f9e2b43840da8a9f3b5cc6825bfb0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (42c10e6) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #306 +/- ##
=======================================
Coverage 39.82% 39.82%
=======================================
Files 101 101
Lines 10894 10894
=======================================
Hits 4338 4338
Misses 6131 6131
Partials 425 425
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily merged pull request #306: Define file system operation interface
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #306:
URL: https://github.com/apache/skywalking-banyandb/pull/306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] HHoflittlefish777 commented on a diff in pull request #306: Define file system operation interface
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on code in PR #306:
URL: https://github.com/apache/skywalking-banyandb/pull/306#discussion_r1278803512
##########
dist/LICENSE:
##########
@@ -456,6 +456,7 @@ MIT licenses
fill-range 7.0.1 MIT
follow-redirects 1.15.2 MIT
form-data 4.0.0 MIT
+ fsevents 2.3.2 MIT
Review Comment:
This is I run make license-dep and it generate automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] HHoflittlefish777 commented on a diff in pull request #306: Define file system operation interface
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on code in PR #306:
URL: https://github.com/apache/skywalking-banyandb/pull/306#discussion_r1278803512
##########
dist/LICENSE:
##########
@@ -456,6 +456,7 @@ MIT licenses
fill-range 7.0.1 MIT
follow-redirects 1.15.2 MIT
form-data 4.0.0 MIT
+ fsevents 2.3.2 MIT
Review Comment:
It generates automatically when I run 'make license-dep'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] HHoflittlefish777 commented on a diff in pull request #306: Define file system operation interface
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on code in PR #306:
URL: https://github.com/apache/skywalking-banyandb/pull/306#discussion_r1278803512
##########
dist/LICENSE:
##########
@@ -456,6 +456,7 @@ MIT licenses
fill-range 7.0.1 MIT
follow-redirects 1.15.2 MIT
form-data 4.0.0 MIT
+ fsevents 2.3.2 MIT
Review Comment:
It generates automatically when I run `make license-dep`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org