You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "hardyfish (via GitHub)" <gi...@apache.org> on 2023/02/16 10:02:34 UTC

[GitHub] [rocketmq] hardyfish commented on pull request #6095: [ISSUE #6094 ]delete rebundant code

hardyfish commented on PR #6095:
URL: https://github.com/apache/rocketmq/pull/6095#issuecomment-1432826421

   > Hi @hardyfish IMO, This code does not need to be deleted, and the code expression is now clearer. The default branch is returned in other cases. And the AclConstants.DENY branch returns Permission.DENY just the same.
   
   yes, the original code is logically clear, but from the function is redundant code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org