You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/01/06 08:30:26 UTC
[GitHub] [incubator-pegasus] hycdong opened a new pull request #867: feat(online_migration): part4 - add script to update table ingest_behind
hycdong opened a new pull request #867:
URL: https://github.com/apache/incubator-pegasus/pull/867
As #851 show, we decide to support online migration.
This pull request adds a script to update table envs and reopen all partitions to make rocksdb option updated.
Usage：`./scripts/pegasus_update_ingest_behind.sh <cluster-name> <cluster-meta-list> <app_name> <ingestion_behind>`
For example：
```
./scripts/pegasus_update_ingest_behind.sh onebox 127.0.0.1:34601,127.0.0.1:34602 temp false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] hycdong merged pull request #867: feat(online_migration): part4 - add script to update table ingest_behind
Posted by GitBox <gi...@apache.org>.
hycdong merged pull request #867:
URL: https://github.com/apache/incubator-pegasus/pull/867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] hycdong commented on a change in pull request #867: feat(online_migration): part4 - add script to update table ingest_behind
Posted by GitBox <gi...@apache.org>.
hycdong commented on a change in pull request #867:
URL: https://github.com/apache/incubator-pegasus/pull/867#discussion_r781790174
##########
File path: scripts/pegasus_rebalance_cluster.sh
##########
@@ -49,13 +49,6 @@ pwd="$( cd "$( dirname "$0" )" && pwd )"
shell_dir="$( cd $pwd/.. && pwd )"
cd $shell_dir
-source ./scripts/minos_common.sh
-find_cluster $cluster
-if [ $? -ne 0 ]; then
- echo "ERROR: cluster \"$cluster\" not found"
- exit 1
-fi
-
Review comment:
The rebalance script doesn't use any command of minos, only remains the cluster name check. Current scripts who call it all do cluster name check before, deleting it will not affect current scripts.
`add_ingest_behind_script` call rebalance but won't rely on minos, so I delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Shuo-Jia commented on a change in pull request #867: feat(online_migration): part4 - add script to update table ingest_behind
Posted by GitBox <gi...@apache.org>.
Shuo-Jia commented on a change in pull request #867:
URL: https://github.com/apache/incubator-pegasus/pull/867#discussion_r781786138
##########
File path: scripts/pegasus_rebalance_cluster.sh
##########
@@ -49,13 +49,6 @@ pwd="$( cd "$( dirname "$0" )" && pwd )"
shell_dir="$( cd $pwd/.. && pwd )"
cd $shell_dir
-source ./scripts/minos_common.sh
-find_cluster $cluster
-if [ $? -ne 0 ]; then
- echo "ERROR: cluster \"$cluster\" not found"
- exit 1
-fi
-
Review comment:
why delete？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org