You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/03/05 07:47:18 UTC
[GitHub] [netbeans-html4j] dukescript opened a new pull request #32: Modelprocessor fix
dukescript opened a new pull request #32:
URL: https://github.com/apache/netbeans-html4j/pull/32
ModelProcessor does not resolve the FQN of Model Type Properties in @ComputedProperty and @OnReceive if they are in a different package. Instead it uses a wrong FQN and the compilation fails. Added a test and a fix. The fix generates imports in the import section of the class instead of using FQNs everywhere, which I think also improves readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-html4j] jtulach commented on pull request #32: Modelprocessor fix
Posted by GitBox <gi...@apache.org>.
jtulach commented on pull request #32:
URL: https://github.com/apache/netbeans-html4j/pull/32#issuecomment-791243583
The test seems to properly simulate the failure:
```bash
netbeans-html4j$ git checkout fa03542b83fa48e551e11d70a57a8104b3b38235
netbeans-html4j$ JAVA_HOME=/jdk-8/ mvn clean install
[ERROR] json/target/test-classes/net/java/html/json/Address.java:[9,22] error: cannot find symbol
[ERROR] symbol: class Street
[ERROR] location: package net.java.html.json
[ERROR] json/target/test-classes/net/java/html/json/Address.java:[89,8] error: cannot find symbol
[ERROR] symbol: class Telephone
[ERROR] location: class net.java.html.json.Address.Html4JavaType
[ERROR] json/target/test-classes/net/java/html/json/Address.java:[90,52] error: cannot find symbol
[ERROR] symbol: class Telephone
[ERROR] location: class net.java.html.json.Address.Html4JavaType
```
now let's test the fix:
```bash
netbeans-html4j$ git checkout 9ec2954b9572da52c585e14922ab07142d23d2dc
netbeans-html4j$ JAVA_HOME=/jdk-8/ mvn clean install
```
this passes OK locally. Let's wait for travis to confirm this on the server and integrate then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-html4j] JaroslavTulach merged pull request #32: Modelprocessor fix
Posted by GitBox <gi...@apache.org>.
JaroslavTulach merged pull request #32:
URL: https://github.com/apache/netbeans-html4j/pull/32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists