You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by Imba Jin <ji...@apache.org> on 2023/05/30 15:35:39 UTC
[Discussion] Setback GitHub Action option to "only require approval first time" for Non-committer
Hi, Recently, ASF changed their default option for "GitHub Action" to
"always require approval for external contributors". [1]
https://infra.apache.org/github-actions-policy.html
> Projects that have a strong desire to use the “only require approval
first time” option should communicate that, explaining their reasons, in a
Jira ticket for Infra.
> Projects will be allowed to continue using the "only require approval
first time" feature,
> provided they affirm that they will actively monitor their workflows for
abuse and act accordingly.
> Failure to do so may result in the workflow settings being switched back
to "always require approval for external contributors".
And now we need to approve the CI/action running for each push (only free
for the committer),
but we don't have the potential problem above. We believe that requiring
approval for every commit will significantly reduce the CI efficiency for
PRs,
and delay the development process. We also assure the ASF community that we
will review every PR carefully to ensure that they do not abuse any
permissions or API calls.
If the PMC/Comitters agree with the default option setback, please reply +1
in this mail thread
Thanks
Imba Jin
Re: [Discussion] Setback GitHub Action option to "only require approval first time" for Non-committer
Posted by Yan Zhang <va...@apache.org>.
+1
On 2023/05/30 15:35:39 Imba Jin wrote:
> Hi, Recently, ASF changed their default option for "GitHub Action" to
> "always require approval for external contributors". [1]
>
> https://infra.apache.org/github-actions-policy.html
>
> > Projects that have a strong desire to use the “only require approval
> first time” option should communicate that, explaining their reasons, in a
> Jira ticket for Infra.
> > Projects will be allowed to continue using the "only require approval
> first time" feature,
> > provided they affirm that they will actively monitor their workflows for
> abuse and act accordingly.
> > Failure to do so may result in the workflow settings being switched back
> to "always require approval for external contributors".
>
> And now we need to approve the CI/action running for each push (only free
> for the committer),
> but we don't have the potential problem above. We believe that requiring
> approval for every commit will significantly reduce the CI efficiency for
> PRs,
> and delay the development process. We also assure the ASF community that we
> will review every PR carefully to ensure that they do not abuse any
> permissions or API calls.
>
>
> If the PMC/Comitters agree with the default option setback, please reply +1
> in this mail thread
>
> Thanks
>
> Imba Jin
>
Re: [Discussion] Setback GitHub Action option to "only require approval first time" for Non-committer
Posted by Yan Zhang <va...@apache.org>.
+1
On 2023/05/30 15:35:39 Imba Jin wrote:
> Hi, Recently, ASF changed their default option for "GitHub Action" to
> "always require approval for external contributors". [1]
>
> https://infra.apache.org/github-actions-policy.html
>
> > Projects that have a strong desire to use the “only require approval
> first time” option should communicate that, explaining their reasons, in a
> Jira ticket for Infra.
> > Projects will be allowed to continue using the "only require approval
> first time" feature,
> > provided they affirm that they will actively monitor their workflows for
> abuse and act accordingly.
> > Failure to do so may result in the workflow settings being switched back
> to "always require approval for external contributors".
>
> And now we need to approve the CI/action running for each push (only free
> for the committer),
> but we don't have the potential problem above. We believe that requiring
> approval for every commit will significantly reduce the CI efficiency for
> PRs,
> and delay the development process. We also assure the ASF community that we
> will review every PR carefully to ensure that they do not abuse any
> permissions or API calls.
>
>
> If the PMC/Comitters agree with the default option setback, please reply +1
> in this mail thread
>
> Thanks
>
> Imba Jin
>
Re: [Discussion] Setback GitHub Action option to "only require approval first time" for Non-committer
Posted by Shiming Zhang <mi...@apache.org>.
+1
On 2023/05/30 15:35:39 Imba Jin wrote:
> Hi, Recently, ASF changed their default option for "GitHub Action" to
> "always require approval for external contributors". [1]
>
> https://infra.apache.org/github-actions-policy.html
>
> > Projects that have a strong desire to use the “only require approval
> first time” option should communicate that, explaining their reasons, in a
> Jira ticket for Infra.
> > Projects will be allowed to continue using the "only require approval
> first time" feature,
> > provided they affirm that they will actively monitor their workflows for
> abuse and act accordingly.
> > Failure to do so may result in the workflow settings being switched back
> to "always require approval for external contributors".
>
> And now we need to approve the CI/action running for each push (only free
> for the committer),
> but we don't have the potential problem above. We believe that requiring
> approval for every commit will significantly reduce the CI efficiency for
> PRs,
> and delay the development process. We also assure the ASF community that we
> will review every PR carefully to ensure that they do not abuse any
> permissions or API calls.
>
>
> If the PMC/Comitters agree with the default option setback, please reply +1
> in this mail thread
>
> Thanks
>
> Imba Jin
>
Re: [Discussion] Setback GitHub Action option to "only require approval first time" for Non-committer
Posted by 126 <zc...@126.com>.
+1
Thanks,
Cong Zhao
> 在 2023年5月31日，20:38，Jermy Li <ja...@gmail.com> 写道：
>
> +1 for the CI efficiency
>
> --
>
> Regards,
>
>
> Jermy Li | Senior Software Engineer
>
> jermy@apache.org | github-id: github.com/javeme
> Haidian District,Beijing,China
>
>
> Jacky Yang <ya...@apache.org> 于2023年5月31日周三 12:57写道：
>
>> +1
>>
>>> On 2023/05/30 15:35:39 Imba Jin wrote:
>>> Hi, Recently, ASF changed their default option for "GitHub Action" to
>>> "always require approval for external contributors". [1]
>>>
>>> https://infra.apache.org/github-actions-policy.html
>>>
>>>> Projects that have a strong desire to use the “only require approval
>>> first time” option should communicate that, explaining their reasons, in
>> a
>>> Jira ticket for Infra.
>>>> Projects will be allowed to continue using the "only require approval
>>> first time" feature,
>>>> provided they affirm that they will actively monitor their workflows
>> for
>>> abuse and act accordingly.
>>>> Failure to do so may result in the workflow settings being switched
>> back
>>> to "always require approval for external contributors".
>>>
>>> And now we need to approve the CI/action running for each push (only free
>>> for the committer),
>>> but we don't have the potential problem above. We believe that requiring
>>> approval for every commit will significantly reduce the CI efficiency for
>>> PRs,
>>> and delay the development process. We also assure the ASF community that
>> we
>>> will review every PR carefully to ensure that they do not abuse any
>>> permissions or API calls.
>>>
>>>
>>> If the PMC/Comitters agree with the default option setback, please reply
>> +1
>>> in this mail thread
>>>
>>> Thanks
>>>
>>> Imba Jin
>>>
>>
Re: [Discussion] Setback GitHub Action option to "only require approval first time" for Non-committer
Posted by Jermy Li <ja...@gmail.com>.
+1 for the CI efficiency
--
Regards,
Jermy Li | Senior Software Engineer
jermy@apache.org | github-id: github.com/javeme
Haidian District,Beijing,China
Jacky Yang <ya...@apache.org> 于2023年5月31日周三 12:57写道：
> +1
>
> On 2023/05/30 15:35:39 Imba Jin wrote:
> > Hi, Recently, ASF changed their default option for "GitHub Action" to
> > "always require approval for external contributors". [1]
> >
> > https://infra.apache.org/github-actions-policy.html
> >
> > > Projects that have a strong desire to use the “only require approval
> > first time” option should communicate that, explaining their reasons, in
> a
> > Jira ticket for Infra.
> > > Projects will be allowed to continue using the "only require approval
> > first time" feature,
> > > provided they affirm that they will actively monitor their workflows
> for
> > abuse and act accordingly.
> > > Failure to do so may result in the workflow settings being switched
> back
> > to "always require approval for external contributors".
> >
> > And now we need to approve the CI/action running for each push (only free
> > for the committer),
> > but we don't have the potential problem above. We believe that requiring
> > approval for every commit will significantly reduce the CI efficiency for
> > PRs,
> > and delay the development process. We also assure the ASF community that
> we
> > will review every PR carefully to ensure that they do not abuse any
> > permissions or API calls.
> >
> >
> > If the PMC/Comitters agree with the default option setback, please reply
> +1
> > in this mail thread
> >
> > Thanks
> >
> > Imba Jin
> >
>
Re: [Discussion] Setback GitHub Action option to "only require approval first time" for Non-committer
Posted by Jacky Yang <ya...@apache.org>.
+1
On 2023/05/30 15:35:39 Imba Jin wrote:
> Hi, Recently, ASF changed their default option for "GitHub Action" to
> "always require approval for external contributors". [1]
>
> https://infra.apache.org/github-actions-policy.html
>
> > Projects that have a strong desire to use the “only require approval
> first time” option should communicate that, explaining their reasons, in a
> Jira ticket for Infra.
> > Projects will be allowed to continue using the "only require approval
> first time" feature,
> > provided they affirm that they will actively monitor their workflows for
> abuse and act accordingly.
> > Failure to do so may result in the workflow settings being switched back
> to "always require approval for external contributors".
>
> And now we need to approve the CI/action running for each push (only free
> for the committer),
> but we don't have the potential problem above. We believe that requiring
> approval for every commit will significantly reduce the CI efficiency for
> PRs,
> and delay the development process. We also assure the ASF community that we
> will review every PR carefully to ensure that they do not abuse any
> permissions or API calls.
>
>
> If the PMC/Comitters agree with the default option setback, please reply +1
> in this mail thread
>
> Thanks
>
> Imba Jin
>