You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2024/05/23 15:24:37 UTC
Change in asterixdb[master]: [NO ISSUE][OTH] Reduce disk cache log verbosity
From Wail Alkowaileet <wa...@gmail.com>:
Wail Alkowaileet has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18313 )
Change subject: [NO ISSUE][OTH] Reduce disk cache log verbosity
......................................................................
[NO ISSUE][OTH] Reduce disk cache log verbosity
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Move to disk pressure log to debug if no presure
- Increase disk cache monitoring interval to 120s
Change-Id: Ib5f77323c3c8af932175c0c42446d6d959b07030
---
M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/filesystem/HolePuncherProvider.java
M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java
M hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/filesystem/PhysicalDrive.java
3 files changed, 30 insertions(+), 7 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/13/18313/1
diff --git a/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/filesystem/HolePuncherProvider.java b/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/filesystem/HolePuncherProvider.java
index a2cdda8..eb125f3 100644
--- a/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/filesystem/HolePuncherProvider.java
+++ b/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/filesystem/HolePuncherProvider.java
@@ -18,9 +18,6 @@
*/
package org.apache.asterix.cloud.lazy.filesystem;
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
-
import java.io.IOException;
import java.nio.ByteBuffer;
@@ -32,6 +29,8 @@
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.io.IFileHandle;
import org.apache.hyracks.cloud.filesystem.FileSystemOperationDispatcherUtil;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
public final class HolePuncherProvider {
private static final Logger LOGGER = LogManager.getLogger();
diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java
index dd90f1a..ea12621 100644
--- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java
+++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java
@@ -52,7 +52,7 @@
CLOUD_STORAGE_ALLOCATION_PERCENTAGE(DOUBLE, 0.8d),
// 90% of the allocated space for storage (i.e., 90% of the 80% of the total disk space)
CLOUD_STORAGE_SWEEP_THRESHOLD_PERCENTAGE(DOUBLE, 0.9d),
- CLOUD_STORAGE_DISK_MONITOR_INTERVAL(POSITIVE_INTEGER, 60),
+ CLOUD_STORAGE_DISK_MONITOR_INTERVAL(POSITIVE_INTEGER, 120),
CLOUD_STORAGE_INDEX_INACTIVE_DURATION_THRESHOLD(POSITIVE_INTEGER, 360),
CLOUD_STORAGE_DEBUG_MODE_ENABLED(BOOLEAN, false),
CLOUD_STORAGE_DEBUG_SWEEP_THRESHOLD_SIZE(LONG_BYTE_UNIT, StorageUtil.getLongSizeInBytes(1, GIGABYTE)),
@@ -124,7 +124,7 @@
case CLOUD_STORAGE_DISK_MONITOR_INTERVAL:
return "The disk monitoring interval time (in seconds): determines how often the system"
+ " checks for pressure on disk space when using the 'selective' caching policy."
- + " (default : 60 seconds)";
+ + " (default : 120 seconds)";
case CLOUD_STORAGE_INDEX_INACTIVE_DURATION_THRESHOLD:
return "The duration in minutes to consider an index is inactive. (default: 360 or 6 hours)";
case CLOUD_STORAGE_DEBUG_MODE_ENABLED:
diff --git a/hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/filesystem/PhysicalDrive.java b/hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/filesystem/PhysicalDrive.java
index 6a2d9c8..e4fefa5 100644
--- a/hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/filesystem/PhysicalDrive.java
+++ b/hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/filesystem/PhysicalDrive.java
@@ -56,8 +56,15 @@
long usedSpace = getUsedSpace();
boolean isPressured = usedSpace > pressureSize;
pressured.set(isPressured);
- LOGGER.info("Used space: {}, pressureCapacity: {} (isPressured: {})",
- StorageUtil.toHumanReadableSize(usedSpace), StorageUtil.toHumanReadableSize(pressureSize), isPressured);
+
+ if (isPressured) {
+ LOGGER.info("Used space: {}, pressureCapacity: {} (isPressured: {})",
+ StorageUtil.toHumanReadableSize(usedSpace), StorageUtil.toHumanReadableSize(pressureSize), true);
+ } else {
+ LOGGER.debug("Used space: {}, pressureCapacity: {} (isPressured: {})",
+ StorageUtil.toHumanReadableSize(usedSpace), StorageUtil.toHumanReadableSize(pressureSize), false);
+ }
+
return isPressured;
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18313
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ib5f77323c3c8af932175c0c42446d6d959b07030
Gerrit-Change-Number: 18313
Gerrit-PatchSet: 1
Gerrit-Owner: Wail Alkowaileet <wa...@gmail.com>
Gerrit-MessageType: newchange