You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/28 04:53:51 UTC
[GitHub] [apisix] iamayushdas opened a new pull request #3921: docs: tells users where they are
iamayushdas opened a new pull request #3921:
URL: https://github.com/apache/apisix/pull/3921
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
___
### Bugfix
- Description
tells users where they are in sidebar
- How to fix?
added a label of Apache Apisix to sidebar
___
### New feature or improvement
- Describe the details and related test reports.
___
### Backport patches
- Why need to backport?
- Source branch
https://github.com/iamayushdas/apisix/tree/sidebar
- Related commits and pull requests
https://github.com/apache/apisix-website/issues/230
- Target branch
https://github.com/apache/apisix/tree/master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #3921: docs: tells users where they are
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #3921:
URL: https://github.com/apache/apisix/pull/3921#issuecomment-808880055
@iamayushdas
please have a look at TEST 9 in `t/admin/plugins.t`
```
# Failed test 'TEST 9: confirm the plugin of auth type - response_body - like (repeated req 0, req 0)'
# at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm line 1586.
# '[{"name":"openid-connect","priority":2599},{"name":"wolf-rbac","priority":2555},{"name":"hmac-auth","priority":2530},{"name":"basic-auth","priority":2520},{"name":"jwt-auth","priority":2510},{"name":"key-auth","priority":2500},{"name":"authz-keycloak","priority":2000}]
# '
# doesn't match '(?^:\[\{"name":"wolf-rbac","priority":2555\},\{"name":"hmac-auth","priority":2530\},\{"name":"basic-auth","priority":2520\},\{"name":"jwt-auth","priority":2510\},\{"name":"key-auth","priority":2500\}\])'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] iamayushdas closed pull request #3921: docs: tells users where they are
Posted by GitBox <gi...@apache.org>.
iamayushdas closed pull request #3921:
URL: https://github.com/apache/apisix/pull/3921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] iamayushdas commented on a change in pull request #3921: docs: tells users where they are
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #3921:
URL: https://github.com/apache/apisix/pull/3921#discussion_r602873810
##########
File path: apisix/plugins/openid-connect.lua
##########
@@ -101,6 +101,7 @@ local schema = {
local _M = {
version = 0.1,
priority = 2599,
+ type = 'auth',
Review comment:
Oh yes yes, I forgot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3921: docs: tells users where they are
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #3921:
URL: https://github.com/apache/apisix/pull/3921#discussion_r602869421
##########
File path: apisix/plugins/openid-connect.lua
##########
@@ -101,6 +101,7 @@ local schema = {
local _M = {
version = 0.1,
priority = 2599,
+ type = 'auth',
Review comment:
🤔 This is not belonged to Auth plugin AFAIK, there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] iamayushdas commented on pull request #3921: docs: tells users where they are
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #3921:
URL: https://github.com/apache/apisix/pull/3921#issuecomment-808850142
@nic-chen some tests are failing can you look into this 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] iamayushdas commented on pull request #3921: docs: tells users where they are
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #3921:
URL: https://github.com/apache/apisix/pull/3921#issuecomment-808877673
@juzhiyuan have a look , in to this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org