You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2021/02/06 04:31:58 UTC
[kudu-CR] rpc: reduce logging when server is shutting down
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17032
Change subject: rpc: reduce logging when server is shutting down
......................................................................
rpc: reduce logging when server is shutting down
TxnCommitITest.TestRestartingWhileCommittingAndDeleting exercises the
case where the client RPCs are sent to the tserver as the tserver is
shutting down. This results in several log messages like:
I0205 05:01:20.190737 1310 messenger.cc:384] service kudu.tserver.TabletServerAdminService not registered on TabletServer
I0205 05:01:20.190891 1310 messenger.cc:384] service kudu.tserver.TabletServerAdminService not registered on TabletServer
I0205 05:01:20.194700 1310 messenger.cc:384] service kudu.tserver.TabletServerAdminService not registered on TabletServer
until the RPC timeout is reached. This message only seems interesting to
clients in cases outside the normal operation of a cluster, e.g. if the
endpoint actually doesn't exist, versus if we're just starting up or
shutting down. This patch adjusts the logging to reflect that.
Change-Id: I943a192bc12e3bae534b9129ac4ea8d24404adc6
---
M src/kudu/rpc/messenger.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/17032/1
--
To view, visit http://gerrit.cloudera.org:8080/17032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I943a192bc12e3bae534b9129ac4ea8d24404adc6
Gerrit-Change-Number: 17032
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] rpc: reduce logging when server is shutting down
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17032 )
Change subject: rpc: reduce logging when server is shutting down
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I943a192bc12e3bae534b9129ac4ea8d24404adc6
Gerrit-Change-Number: 17032
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 06 Feb 2021 05:43:00 +0000
Gerrit-HasComments: No
[kudu-CR] rpc: reduce logging when server is shutting down
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: rpc: reduce logging when server is shutting down
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I943a192bc12e3bae534b9129ac4ea8d24404adc6
Gerrit-Change-Number: 17032
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] rpc: reduce logging when server is shutting down
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17032 )
Change subject: rpc: reduce logging when server is shutting down
......................................................................
rpc: reduce logging when server is shutting down
TxnCommitITest.TestRestartingWhileCommittingAndDeleting exercises the
case where the client RPCs are sent to the tserver as the tserver is
shutting down. This results in several log messages like:
I0205 05:01:20.190737 1310 messenger.cc:384] service kudu.tserver.TabletServerAdminService not registered on TabletServer
I0205 05:01:20.190891 1310 messenger.cc:384] service kudu.tserver.TabletServerAdminService not registered on TabletServer
I0205 05:01:20.194700 1310 messenger.cc:384] service kudu.tserver.TabletServerAdminService not registered on TabletServer
until the RPC timeout is reached. This message only seems interesting to
clients in cases outside the normal operation of a cluster, e.g. if the
endpoint actually doesn't exist, versus if we're just starting up or
shutting down. This patch adjusts the logging to reflect that.
Change-Id: I943a192bc12e3bae534b9129ac4ea8d24404adc6
Reviewed-on: http://gerrit.cloudera.org:8080/17032
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/rpc/messenger.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Hao Hao: Looks good to me, approved
Andrew Wong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I943a192bc12e3bae534b9129ac4ea8d24404adc6
Gerrit-Change-Number: 17032
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] rpc: reduce logging when server is shutting down
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17032 )
Change subject: rpc: reduce logging when server is shutting down
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I943a192bc12e3bae534b9129ac4ea8d24404adc6
Gerrit-Change-Number: 17032
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 06 Feb 2021 05:00:26 +0000
Gerrit-HasComments: No