You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "craigcondit (via GitHub)" <gi...@apache.org> on 2023/06/20 21:49:44 UTC
[GitHub] [yunikorn-core] craigcondit opened a new pull request, #576: [YUNIKORN-1825] Convert core to use scoped logging
craigcondit opened a new pull request, #576:
URL: https://github.com/apache/yunikorn-core/pull/576
Convert all uses of log.Logger() to log.Log(name). This allows for fine-grained control over logging for each subsystem.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [x] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1825
### How should this be tested?
No functionality is changed, only the logging method.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #576: [YUNIKORN-1825] Convert core to use scoped logging
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #576:
URL: https://github.com/apache/yunikorn-core/pull/576#issuecomment-1599616722
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#576](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (325d7f5) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/5f509ff8fb903c6e883211782f2f30c04a31ea50?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5f509ff) will **decrease** coverage by `0.04%`.
> The diff coverage is `58.15%`.
```diff
@@ Coverage Diff @@
## master #576 +/- ##
==========================================
- Coverage 75.58% 75.55% -0.04%
==========================================
Files 74 74
Lines 12137 12134 -3
==========================================
- Hits 9174 9168 -6
- Misses 2642 2645 +3
Partials 321 321
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/common/server.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2NvbW1vbi9zZXJ2ZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/log/logger.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2xvZy9sb2dnZXIuZ28=) | `86.61% <ø> (-2.35%)` | :arrow_down: |
| [pkg/metrics/queue.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL21ldHJpY3MvcXVldWUuZ28=) | `80.00% <0.00%> (ø)` | |
| [pkg/metrics/runtime.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL21ldHJpY3MvcnVudGltZS5nbw==) | `91.13% <0.00%> (ø)` | |
| [pkg/metrics/scheduler.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL21ldHJpY3Mvc2NoZWR1bGVyLmdv) | `51.85% <0.00%> (ø)` | |
| [pkg/scheduler/scheduler.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9zY2hlZHVsZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/trace/scheduler\_tracer.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3RyYWNlL3NjaGVkdWxlcl90cmFjZXIuZ28=) | `82.69% <0.00%> (ø)` | |
| [pkg/webservice/state\_dump.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3dlYnNlcnZpY2Uvc3RhdGVfZHVtcC5nbw==) | `70.00% <0.00%> (ø)` | |
| [pkg/webservice/webservice.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3dlYnNlcnZpY2Uvd2Vic2VydmljZS5nbw==) | `12.19% <0.00%> (ø)` | |
| [pkg/metrics/metrics\_collector.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL21ldHJpY3MvbWV0cmljc19jb2xsZWN0b3IuZ28=) | `65.90% <20.00%> (ø)` | |
| ... and [35 more](https://app.codecov.io/gh/apache/yunikorn-core/pull/576?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #576: [YUNIKORN-1825] Convert core to use scoped logging
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #576: [YUNIKORN-1825] Convert core to use scoped logging
URL: https://github.com/apache/yunikorn-core/pull/576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org