You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ivandasch (via GitHub)" <gi...@apache.org> on 2023/06/13 11:14:46 UTC

[GitHub] [ignite] ivandasch commented on a diff in pull request #10769: IGNITE-19588 SQL Calcite: Add long-running queries warnings

ivandasch commented on code in PR #10769:
URL: https://github.com/apache/ignite/pull/10769#discussion_r1227953672


##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/CalciteQueryProcessor.java:
##########
@@ -534,7 +519,7 @@ private <T> T processQuery(
             params,
             qryCtx,
             exchangeSvc,
-            (q) -> qryReg.unregister(q.id()),
+            (q, f) -> qryReg.unregister(q.id(), f),

Review Comment:
   It seems that it is better to rename `f` to `ex`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org