You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ch...@apache.org on 2018/08/09 19:54:10 UTC
[04/10] [lang] LANG-1402: refactored to return default value on
negative index
LANG-1402: refactored to return default value on negative index
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/7721302a
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/7721302a
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/7721302a
Branch: refs/heads/master
Commit: 7721302ae5d70d2986d74ae7e7df648bf849997d
Parents: 625fbcc
Author: MarkDacek <ma...@richmond.edu>
Authored: Sun Jul 8 19:11:19 2018 -0400
Committer: MarkDacek <ma...@richmond.edu>
Committed: Sun Jul 8 19:11:19 2018 -0400
----------------------------------------------------------------------
src/main/java/org/apache/commons/lang3/ArrayUtils.java | 2 +-
src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/7721302a/src/main/java/org/apache/commons/lang3/ArrayUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/ArrayUtils.java b/src/main/java/org/apache/commons/lang3/ArrayUtils.java
index 8b7e319..7a5f950 100644
--- a/src/main/java/org/apache/commons/lang3/ArrayUtils.java
+++ b/src/main/java/org/apache/commons/lang3/ArrayUtils.java
@@ -8700,7 +8700,7 @@ public class ArrayUtils {
}
if(index < 0 ){
- index = 0;
+ return defaultReturn;
}
return array[index];
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/7721302a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
index 984184c..0121473 100644
--- a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
@@ -5125,7 +5125,7 @@ public class ArrayUtilsTest {
assertEquals("Test", ArrayUtils.get(array, 10, "Test"));
//negative index
- assertEquals("Hello World", ArrayUtils.get(array, -1));
+ assertEquals("Default", ArrayUtils.get(array, -1, "Default"));
}
@Test