[GitHub] [accumulo] milleruntime commented on a change in pull request #2592: Configure block cache for Recovery

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #2592:
URL: https://github.com/apache/accumulo/pull/2592#discussion_r836380755



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/log/RecoveryLogsIterator.java
##########
@@ -79,7 +86,8 @@ public RecoveryLogsIterator(ServerContext context, List<Path> recoveryLogDirs, L
 
       for (Path log : logFiles) {
         var scanner = RFile.newScanner().from(log.toString()).withFileSystem(fs)
-            .withTableProperties(context.getConfiguration()).build();
+            .withTableProperties(context.getConfiguration()).withDataCache(dataCacheSize)

Review comment:
       OK that is what I thought. I thought this was at least better than what we have now.
   
   > would not want to use the scan block cache for this
   
   What do you mean?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org