You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/08/16 12:59:01 UTC
[GitHub] [cordova-android] Sharavanan7944 opened a new pull request #1326: 8.1.x
Sharavanan7944 opened a new pull request #1326:
URL: https://github.com/apache/cordova-android/pull/1326
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1326: 8.1.x
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1326:
URL: https://github.com/apache/cordova-android/pull/1326#issuecomment-899577831
Thank you for the PR, but Cordova isn't supporting 8.x anymore.
Of course, you can always use the changes in your own projects as necessary but we would recommend upgrading your cordova-android version to the latest if possible. Cordova-android@10 will use gradle 7.1.1 by default, which contains the requirements for android 11 package visibility.
Kind regards,
Norman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek closed pull request #1326: 8.1.x
Posted by GitBox <gi...@apache.org>.
breautek closed pull request #1326:
URL: https://github.com/apache/cordova-android/pull/1326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] Sharavanan7944 commented on pull request #1326: 8.1.x
Posted by GitBox <gi...@apache.org>.
Sharavanan7944 commented on pull request #1326:
URL: https://github.com/apache/cordova-android/pull/1326#issuecomment-899561897
Changed gradle version to support android 11 package visibility to be configured if necessary
https://developer.android.com/about/versions/11/privacy/package-visibility
To prepare for package visibility need gradle patch as per docs
https://android-developers.googleblog.com/2020/07/preparing-your-build-for-package-visibility-in-android-11.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek edited a comment on pull request #1326: 8.1.x
Posted by GitBox <gi...@apache.org>.
breautek edited a comment on pull request #1326:
URL: https://github.com/apache/cordova-android/pull/1326#issuecomment-899577831
Thank you for the PR, but Apache Cordova isn't supporting 8.x anymore.
Of course, you can always use the changes in your own projects as necessary but we would recommend upgrading your cordova-android version to the latest if possible. Cordova-android@10 will use gradle 7.1.1 by default, which contains the requirements for android 11 package visibility.
Kind regards,
Norman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org