You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by jm...@apache.org on 2011/08/17 06:21:33 UTC
Review Request: FLUME-742: TestAvroSinks fails
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1543/
-----------------------------------------------------------
Review request for Flume, Arvind Prabhakar, jmhsieh, and Tom White.
Summary
-------
Posted on review board for Tom White. (use /trunk/ as base dir, or use flume-git and post gt post).
TestAvroSinks apparently is failing but Maven is not reporting the failure! This fixes behavior of the sink and updates to make a valid test.
This addresses bug FLUME-742.
https://issues.apache.org/jira/browse/FLUME-742
Diffs
-----
/trunk/flume-core/src/main/java/com/cloudera/flume/handlers/avro/AvroEventSink.java 1157304
/trunk/flume-core/src/test/java/com/cloudera/flume/handlers/avro/TestAvroSinks.java 1157304
Diff: https://reviews.apache.org/r/1543/diff
Testing
-------
Tom ran TestAvroSinks
Thanks,
jmhsieh
Re: Review Request: FLUME-742: TestAvroSinks fails
Posted by jm...@apache.org.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1543/#review1497
-----------------------------------------------------------
Ship it!
lgtm.
- jmhsieh
On 2011-08-17 04:21:33, jmhsieh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1543/
> -----------------------------------------------------------
>
> (Updated 2011-08-17 04:21:33)
>
>
> Review request for Flume, Arvind Prabhakar, jmhsieh, and Tom White.
>
>
> Summary
> -------
>
> Posted on review board for Tom White. (use /trunk/ as base dir, or use flume-git and post gt post).
>
> TestAvroSinks apparently is failing but Maven is not reporting the failure! This fixes behavior of the sink and updates to make a valid test.
>
>
> This addresses bug FLUME-742.
> https://issues.apache.org/jira/browse/FLUME-742
>
>
> Diffs
> -----
>
> /trunk/flume-core/src/main/java/com/cloudera/flume/handlers/avro/AvroEventSink.java 1157304
> /trunk/flume-core/src/test/java/com/cloudera/flume/handlers/avro/TestAvroSinks.java 1157304
>
> Diff: https://reviews.apache.org/r/1543/diff
>
>
> Testing
> -------
>
> Tom ran TestAvroSinks
>
>
> Thanks,
>
> jmhsieh
>
>