[GitHub] reddycharan commented on issue #1608: Issue 1578: Fixed deadlock in auditor blocking ZK thread

[GitBox <gi...@apache.org>]

reddycharan commented on issue #1608: Issue 1578: Fixed deadlock in auditor blocking ZK thread
URL: https://github.com/apache/bookkeeper/pull/1608#issuecomment-414848227
 
 
   @merlimat @sijie @ivankelly I've few questions here
   
   1) Is this bug regression or is it been like this since beginning?
   2) Because of this deadlock is it just 'checkAllLedgers' checker which is blocked? or other components which use 'executor' ("auditBookies" checker and core Auditor functionality as well?
   3) If synchronous call - 'admin.openLedgerNoRecovery' in "checkLedgersProcessor" is blocked as you explained, then 'processDone' latch is not counted down, then "processDone.await()" in "checkAllLedgers" will be blocked forever. Which will make 'executor' blocked, since 'executor' is singleThreadScheduledExecutor, then IFIUC all of the Auditor functionality is blocked, right?
   4) why does Issue description say "Auditor run Periodic check only once", if the analysis made for this fix is correct then "checkAllLedgers" shouldn't run even once right?
   5) To begin with, I'm not sure if there is comprehensive testcase for this checker, but I'm little surprised that this commit is merged / issue is closed, with no testcase to prove the analysis of the fix and validness of the fix.
   
   @jvrao @athanatos fyi.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services