You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/22 07:50:57 UTC
[GitHub] [doris] XieJiann opened a new pull request, #14485: [feature](Nereids) Add d phyp job
XieJiann opened a new pull request, #14485:
URL: https://github.com/apache/doris/pull/14485
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on a diff in pull request #14485: [feature](Nereids) Add dphyp job
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #14485:
URL: https://github.com/apache/doris/pull/14485#discussion_r1030493409
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -105,6 +104,14 @@ public Group child(int i) {
return children.get(i);
}
+ public void setChild(int i, Group group) {
+ children.set(i, group);
Review Comment:
set include
- child -> parent
- parent -> child
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -105,6 +104,14 @@ public Group child(int i) {
return children.get(i);
}
+ public void setChild(int i, Group group) {
+ children.set(i, group);
+ }
+
+ public int childrenSize() {
+ return children.size();
+ }
+
Review Comment:
exist `arity()`
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Group.java:
##########
@@ -48,12 +49,11 @@ public class Group {
private final List<GroupExpression> logicalExpressions = Lists.newArrayList();
private final List<GroupExpression> physicalExpressions = Lists.newArrayList();
- private LogicalProperties logicalProperties;
-
// Map of cost lower bounds
// Map required plan props to cost lower bound of corresponding plan
private final Map<PhysicalProperties, Pair<Double, GroupExpression>> lowestCostPlans = Maps.newHashMap();
-
+ private LogicalProperties logicalProperties;
+ private double costLowerBound = -1;
Review Comment:
look like redundant
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -258,4 +263,8 @@ public String toString() {
}
return builder.toString();
}
+
+ public StatsDeriveResult childStatistics(int idx) {
Review Comment:
Observe these two files and find that some code modifications are just to correct the position
look like you use `rearrange code`.
but sometimes it may be better to reduce the original code modification, it benefit cheery-pick
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14485: [feature](Nereids) Add dphyp job
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14485:
URL: https://github.com/apache/doris/pull/14485#issuecomment-1323490888
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.67 seconds
load time: 434 seconds
storage size: 17172814348 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221122110026_clickbench_pr_50715.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] XieJiann commented on a diff in pull request #14485: [feature](Nereids) Add dphyp job
Posted by GitBox <gi...@apache.org>.
XieJiann commented on code in PR #14485:
URL: https://github.com/apache/doris/pull/14485#discussion_r1031010394
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Group.java:
##########
@@ -48,12 +49,11 @@ public class Group {
private final List<GroupExpression> logicalExpressions = Lists.newArrayList();
private final List<GroupExpression> physicalExpressions = Lists.newArrayList();
- private LogicalProperties logicalProperties;
-
// Map of cost lower bounds
// Map required plan props to cost lower bound of corresponding plan
private final Map<PhysicalProperties, Pair<Double, GroupExpression>> lowestCostPlans = Maps.newHashMap();
-
+ private LogicalProperties logicalProperties;
+ private double costLowerBound = -1;
Review Comment:
done
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -105,6 +104,14 @@ public Group child(int i) {
return children.get(i);
}
+ public void setChild(int i, Group group) {
+ children.set(i, group);
Review Comment:
done
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -105,6 +104,14 @@ public Group child(int i) {
return children.get(i);
}
+ public void setChild(int i, Group group) {
+ children.set(i, group);
+ }
+
+ public int childrenSize() {
+ return children.size();
+ }
+
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] XieJiann commented on a diff in pull request #14485: [feature](Nereids) Add dphyp job
Posted by GitBox <gi...@apache.org>.
XieJiann commented on code in PR #14485:
URL: https://github.com/apache/doris/pull/14485#discussion_r1031010508
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -258,4 +263,8 @@ public String toString() {
}
return builder.toString();
}
+
+ public StatsDeriveResult childStatistics(int idx) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] XieJiann commented on a diff in pull request #14485: [feature](Nereids) Add dphyp job
Posted by GitBox <gi...@apache.org>.
XieJiann commented on code in PR #14485:
URL: https://github.com/apache/doris/pull/14485#discussion_r1030998129
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -258,4 +263,8 @@ public String toString() {
}
return builder.toString();
}
+
+ public StatsDeriveResult childStatistics(int idx) {
Review Comment:
Yean, I'll fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener merged pull request #14485: [feature](Nereids) Add dphyp job
Posted by GitBox <gi...@apache.org>.
jackwener merged PR #14485:
URL: https://github.com/apache/doris/pull/14485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org