You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/23 08:09:13 UTC
[GitHub] [flink] godfreyhe opened a new pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
godfreyhe opened a new pull request #14733:
URL: https://github.com/apache/flink/pull/14733
## What is the purpose of the change
*Since all exec node do not extend from LegacyExecNodeBase, we can remove them (LegacyExecNodeBase, LegacyBatchExecNode and LegacyStreamExecNode). And this pr also do some code clean up, such as: rename ExecNode#getDesc to ExecNode#getDescription, fix some typos*
## Brief change log
- *Remove legacy exec nodes*
- *Rename ExecNode#getDesc to ExecNode#getDescription*
- *Move CommonPhysicalJoin and CommonPhysicalLookupJoin to `nodes.physical.common` package*
- *Minor code cleanup for some exec nodes*
## Verifying this change
This change is code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35ecb423c9f73b3797455995731e29b72a380e88 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
}, {
"hash" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406",
"triggerID" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"triggerType" : "PUSH"
}, {
"hash" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408",
"triggerID" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"triggerType" : "PUSH"
}, {
"hash" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408",
"triggerID" : "767255032",
"triggerType" : "MANUAL"
}, {
"hash" : "d1520a7a19f9028db964c2332d22693996299cfe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d1520a7a19f9028db964c2332d22693996299cfe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* de291068835c9b7540c3a0544c6dd589f0c3ada2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408)
* d1520a7a19f9028db964c2332d22693996299cfe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
}, {
"hash" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406",
"triggerID" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"triggerType" : "PUSH"
}, {
"hash" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408",
"triggerID" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"triggerType" : "PUSH"
}, {
"hash" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408",
"triggerID" : "767255032",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* de291068835c9b7540c3a0544c6dd589f0c3ada2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35ecb423c9f73b3797455995731e29b72a380e88 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35ecb423c9f73b3797455995731e29b72a380e88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-767255032
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
}, {
"hash" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406",
"triggerID" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"triggerType" : "PUSH"
}, {
"hash" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408",
"triggerID" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef5b18453605da53ca9c9ce0c7fce9b7361f67a3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406)
* de291068835c9b7540c3a0544c6dd589f0c3ada2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #14733:
URL: https://github.com/apache/flink/pull/14733
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
}, {
"hash" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406",
"triggerID" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35ecb423c9f73b3797455995731e29b72a380e88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404)
* ef5b18453605da53ca9c9ce0c7fce9b7361f67a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765886914
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d1520a7a19f9028db964c2332d22693996299cfe (Fri May 28 08:06:42 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-767255032
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
}, {
"hash" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406",
"triggerID" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"triggerType" : "PUSH"
}, {
"hash" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408",
"triggerID" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"triggerType" : "PUSH"
}, {
"hash" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408",
"triggerID" : "767255032",
"triggerType" : "MANUAL"
}, {
"hash" : "d1520a7a19f9028db964c2332d22693996299cfe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12501",
"triggerID" : "d1520a7a19f9028db964c2332d22693996299cfe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1520a7a19f9028db964c2332d22693996299cfe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12501)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
}, {
"hash" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406",
"triggerID" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"triggerType" : "PUSH"
}, {
"hash" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408",
"triggerID" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"triggerType" : "PUSH"
}, {
"hash" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "767255032",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* de291068835c9b7540c3a0544c6dd589f0c3ada2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
}, {
"hash" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406",
"triggerID" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef5b18453605da53ca9c9ce0c7fce9b7361f67a3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
}, {
"hash" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406",
"triggerID" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"triggerType" : "PUSH"
}, {
"hash" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef5b18453605da53ca9c9ce0c7fce9b7361f67a3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406)
* de291068835c9b7540c3a0544c6dd589f0c3ada2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
}, {
"hash" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406",
"triggerID" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"triggerType" : "PUSH"
}, {
"hash" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408",
"triggerID" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"triggerType" : "PUSH"
}, {
"hash" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408",
"triggerID" : "767255032",
"triggerType" : "MANUAL"
}, {
"hash" : "d1520a7a19f9028db964c2332d22693996299cfe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12501",
"triggerID" : "d1520a7a19f9028db964c2332d22693996299cfe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* de291068835c9b7540c3a0544c6dd589f0c3ada2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408)
* d1520a7a19f9028db964c2332d22693996299cfe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12501)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
}, {
"hash" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35ecb423c9f73b3797455995731e29b72a380e88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404)
* ef5b18453605da53ca9c9ce0c7fce9b7361f67a3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35ecb423c9f73b3797455995731e29b72a380e88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12404",
"triggerID" : "35ecb423c9f73b3797455995731e29b72a380e88",
"triggerType" : "PUSH"
}, {
"hash" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12406",
"triggerID" : "ef5b18453605da53ca9c9ce0c7fce9b7361f67a3",
"triggerType" : "PUSH"
}, {
"hash" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408",
"triggerID" : "de291068835c9b7540c3a0544c6dd589f0c3ada2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* de291068835c9b7540c3a0544c6dd589f0c3ada2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12408)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14733:
URL: https://github.com/apache/flink/pull/14733#issuecomment-765886914
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 109b78814bd15e98f31a858175c7e50793b7d83a (Sat Jan 23 08:11:20 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org