You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tkobayas (via GitHub)" <gi...@apache.org> on 2024/07/08 09:08:02 UTC

[PR] [incubator-kie-drools-6007] Executable model doesn't report an error … [incubator-kie-drools]

tkobayas opened a new pull request, #6013:
URL: https://github.com/apache/incubator-kie-drools/pull/6013

   …when duplicated
   
   * removing kie-ci from dependency, because it causes a test failure in KieBaseIncludeTest
   
   * Use canonicalKieModule.getKiePackages() rather than getKieBase()
   
   * null check for kiePackage
   
   * move populateIncludedRuleNameMap out of packages loop
   
   * removed unused FileManager
   
   * performance improvement. Use getModelForKBase instead of getKiePackages
   
   * Fit into build phases
   
   * clean up
   
   **Issue**:
   * https://github.com/apache/incubator-kie-drools/issues/6007
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [incubator-kie-drools-6007] Executable model doesn't report an error … [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #6013:
URL: https://github.com/apache/incubator-kie-drools/pull/6013#issuecomment-2216170994

   This is a forward port PR of https://github.com/kiegroup/drools/pull/59 and https://github.com/kiegroup/drools/pull/61 from 7.x.
   
   The main branch was refactored to use `Phase` architecture in build, this PR is adjusted to it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [incubator-kie-drools-6007] Executable model doesn't report an error … [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #6013:
URL: https://github.com/apache/incubator-kie-drools/pull/6013#issuecomment-2216175492

   @mariofusco @lucamolteni @pibizza Please review, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [incubator-kie-drools-6007] Executable model doesn't report an error … [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas merged PR #6013:
URL: https://github.com/apache/incubator-kie-drools/pull/6013


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org