You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/28 07:06:36 UTC

[GitHub] [iceberg] kbendick commented on pull request #5135: Core: Fix CreateTableRequest so serialized keys align with spec and ensure field name tests are for serialized JSON values per spec

kbendick commented on PR #5135:
URL: https://github.com/apache/iceberg/pull/5135#issuecomment-1168318281

   > > @kbendick, can you please update this since #5133 was merged and the other fields need to be corrected?
   > 
   > Sure. Probably the easiest way to fix the other names is to rename the class fields. Will do that.
   
   This is done. If we merge this, then https://github.com/apache/iceberg/pull/5118 can be rebased and considered for merging afterwards.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org