[jira] [Commented] (HADOOP-14352) Make some HttpServer2 SSL properties optional

["Robert Kanter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-14352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983366#comment-15983366 ] 

Robert Kanter commented on HADOOP-14352:
----------------------------------------

Thanks [~jzhuge]; here's some comments:
- For your second bullet point (not requiring those configs), I don't see any code changes for that.  I only see code changes for your first bullet point ({{getOptionalPassword}}).  Unless the code already does that?
- In your first bullet point, that would be that the keystoremanager password is not required, right?  The keystore password is required.
- I don't see why the method should be named {{getOptionalPassword}}.  It's really just a wrapper around {{getPassword}} that returns a String instead of a char[], so why not call it {{getPassword}} or {{getPasswordString}}?

> Make some HttpServer2 SSL properties optional
> ---------------------------------------------
>
>                 Key: HADOOP-14352
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14352
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: kms
>    Affects Versions: 3.0.0-alpha2
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Minor
>         Attachments: HADOOP-14352.001.patch
>
>
> {{HttpServer2#loadSSLConfiguration}} loads 5 SSL properties but only keystore location and password are required, the rest of them, keystore keypassword, truststore location, and truststore password, can be optional.
> According to http://www.eclipse.org/jetty/documentation/current/configuring-ssl.html:
> * If there is no keymanagerpassword, then the keystorepassword is used instead.
> * Trust store is typically set to the same path as the keystore.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org