You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2019/02/26 14:50:58 UTC

[GitHub] tbouron commented on a change in pull request #124: DSL Viewer ignored literals; this fixes that and tidies the code a bit

tbouron commented on a change in pull request #124: DSL Viewer ignored literals; this fixes that and tidies the code a bit
URL: https://github.com/apache/brooklyn-ui/pull/124#discussion_r260317447
 
 

 ##########
 File path: ui-modules/blueprint-composer/app/components/dsl-viewer/dsl-viewer.js
 ##########
 @@ -42,18 +42,24 @@ export function dslViewerDirective() {
     };
 
     function link(scope) {
-        scope.isTargetDsl = (dsl) => {
-            return dsl.kind === KIND.TARGET;
+        
+        scope.getIcon = (dsl) => {
 
 Review comment:
   The template now uses `ng-switch` so there is no point of having this function. The class can be directly put into the HTML element. Less code for same result, yay 🎉 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services