You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/09/06 03:51:15 UTC
[GitHub] [bookkeeper] MarvinCai opened a new pull request, #3474: Add option to clean up test ledger after simpletest.
MarvinCai opened a new pull request, #3474:
URL: https://github.com/apache/bookkeeper/pull/3474
### Motivation
resolves: https://github.com/apache/bookkeeper/issues/3473
### Changes
Add option to clean up test ledger after simpletest.
Also add metadata for ledger created by simpletest so we have more confidence when clean them up manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #3474: Add option to clean up test ledger after simpletest.
Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #3474:
URL: https://github.com/apache/bookkeeper/pull/3474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on a diff in pull request #3474: Add option to clean up test ledger after simpletest.
Posted by GitBox <gi...@apache.org>.
dlg99 commented on code in PR #3474:
URL: https://github.com/apache/bookkeeper/pull/3474#discussion_r964061877
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/client/SimpleTestCommand.java:
##########
@@ -96,7 +101,10 @@ protected void run(BookKeeper bk, Flags flags) throws Exception {
lastReport = System.nanoTime();
}
}
- LOG.info("{} entries written to ledger {}", flags.numEntries, wh.getId());
+ LOG.info("{} entries written to ledger {}, cleaning up the ledger", flags.numEntries, wh.getId());
Review Comment:
nit: i'd move logging of "cleaning up the ledger" under `if (flags.cleanup)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org