Re: cvs commit: logging-log4j/src/java/org/apache/log4j/net SMTPAppender.java

[Ceki Gülcü <ce...@qos.ch>]

Hello Scott,

Since we have the possibility of configuring sub-components of
components, the expression parameter should be added to instances of
the appropriate TriggeringEventEvaluator. Once of the reasons behind
the development of Joran was to address the problem of configuring
sub-components of components and in particular passing parameters to
TriggeringEventEvaluator instances was a major motivation.

In other words, I think the expression parameter should be moved from
SMTPAppender into DefaultEvaluator or even to a new Evaluator class.

Also per the guidelines for log4j components [1], DefaultEvaluator
should not invoke LogManager.getLogger().

[1] http://www.qos.ch/logging/internalLogging.jsp


At 08:57 AM 1/4/2005, you wrote:
>sdeboy      2005/01/03 23:57:20
>
>   Modified:    src/java/org/apache/log4j/net SMTPAppender.java
>   Log:
>   SMTPAppender now supports an optional 'expression' param that will 
> cause DefaultEvaluator to use ExpressionRule for trigger evaluation.
>
>   NOTE: TriggeringEventEvaluator and o.a.l.Rule appear similar enough to 
> support consolidation

-- 
Ceki Gülcü

   The complete log4j manual: http://www.qos.ch/log4j/



---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org