You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/11/23 15:37:03 UTC

[GitHub] arina-ielchiieva commented on a change in pull request #1553: DRILL-6868: Upgrade Janino compiler to 3.0.11

arina-ielchiieva commented on a change in pull request #1553: DRILL-6868: Upgrade Janino compiler to 3.0.11
URL: https://github.com/apache/drill/pull/1553#discussion_r235974756
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/MethodGrabbingVisitor.java
 ##########
 @@ -64,9 +67,31 @@ public void traverseClassDeclaration(AbstractClassDeclaration classDeclaration)
     @Override
     public void traverseMethodDeclarator(MethodDeclarator methodDeclarator) {
       if (captureMethods) {
+        // Generate a "labeled statement".
 
 Review comment:
   Please add comments inline explaining each action.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services