You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/10/20 16:23:27 UTC
[GitHub] [incubator-mxnet] mozga-intel opened a new pull request #20684: [master][ci][feature] Prospector tool to analyze Python code
mozga-intel opened a new pull request #20684:
URL: https://github.com/apache/incubator-mxnet/pull/20684
## Description ##
There is used Prospector ' tool to perform additional formatting and semantic checking of code. Prospector is a tool to analyse Python code and output information about errors, potential problems, convention violations and complexity. (Related to: #20406, #20356)
Since Prospector needs to be installed with an appropriate configuration, the file with the requirements has to be run:
```Script
pip install prospector
```
To run a Prospector , open your terminal and type:
```Shell
python3 -m prospector --profile prospector.yaml
```
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20684: [master][ci][feature] Prospector tool to analyze Python code
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20684:
URL: https://github.com/apache/incubator-mxnet/pull/20684#issuecomment-954019851
@mxnet-bot run ci [centos-gpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20684: [master][ci][feature] Prospector tool to analyze Python code
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20684:
URL: https://github.com/apache/incubator-mxnet/pull/20684#issuecomment-947829779
Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [website, sanity, centos-cpu, windows-gpu, unix-cpu, clang, edge, windows-cpu, miscellaneous, centos-gpu, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20684: [master][ci][feature] Prospector tool to analyze Python code
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20684:
URL: https://github.com/apache/incubator-mxnet/pull/20684#discussion_r737244391
##########
File path: tests/tutorials/test_sanity_tutorials.py
##########
@@ -1,99 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
please verify if this file should be deleted. What about md files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20684: [master][ci][feature] Prospector tool to analyze Python code
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20684:
URL: https://github.com/apache/incubator-mxnet/pull/20684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on a change in pull request #20684: [master][ci][feature] Prospector tool to analyze Python code
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on a change in pull request #20684:
URL: https://github.com/apache/incubator-mxnet/pull/20684#discussion_r737387823
##########
File path: tests/tutorials/test_sanity_tutorials.py
##########
@@ -1,99 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Good catch @anko-intel; thanks! I ruled it out, but It looks like that it's still needed on many counts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20684: [master][ci][feature] Prospector tool to analyze Python code
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20684:
URL: https://github.com/apache/incubator-mxnet/pull/20684#issuecomment-954019912
Jenkins CI successfully triggered : [centos-gpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org