You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/03/31 17:56:42 UTC
[GitHub] [incubator-echarts] plainheart opened a new pull request #12360:
fix(toolbox/feature): the event `magictypechanged` should be the type
`tiled` if stack is not enabled. close #12359.
plainheart opened a new pull request #12360: fix(toolbox/feature): the event `magictypechanged` should be the type `tiled` if stack is not enabled. close #12359.
URL: https://github.com/apache/incubator-echarts/pull/12360
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Fix the issue #12359
### Fixed issues
- #12359
### Related test cases
Test case: refer to `test/stack-tiled.html`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12360:
fix(toolbox/feature): the event `magictypechanged` should be the type
`tiled` if stack is not enabled. close #12359.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12360: fix(toolbox/feature): the event `magictypechanged` should be the type `tiled` if stack is not enabled. close #12359.
URL: https://github.com/apache/incubator-echarts/pull/12360#issuecomment-606781035
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] ishowman commented on pull request #12360: fix(toolbox): optimize stack icon toggle experience.
Posted by GitBox <gi...@apache.org>.
ishowman commented on pull request #12360:
URL: https://github.com/apache/incubator-echarts/pull/12360#issuecomment-688115253
> Do it in 5.0.
What's the release date of 5.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on pull request #12360: (WIP) fix(toolbox/feature): the event `magictypechanged` should return the type `tiled` if stack is not enabled. close #12359.
Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #12360:
URL: https://github.com/apache/incubator-echarts/pull/12360#issuecomment-631224874
Converted to draft, there are still some work to be done.
Related issues #12667, #11743, #12359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart closed pull request #12360: fix(toolbox): optimize stack icon toggle experience.
Posted by GitBox <gi...@apache.org>.
plainheart closed pull request #12360:
URL: https://github.com/apache/incubator-echarts/pull/12360
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on a change in pull request #12360: fix(toolbox): optimize stack icon toggle experience.
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #12360:
URL: https://github.com/apache/incubator-echarts/pull/12360#discussion_r465141997
##########
File path: src/component/toolbox/ToolboxView.js
##########
@@ -147,8 +149,36 @@ export default echarts.extendComponentView({
icons[featureName] = icon;
titles[featureName] = title;
}
+
var iconPaths = featureModel.iconPaths = {};
zrUtil.each(icons, function (iconStr, iconName) {
+ // `tiled` is just for changing stack toggle icon, no need to add a path.
+ if (isMagicType && iconName === 'tiled') {
+ return;
Review comment:
It's better to put this logic in the `render` and `updateView` method of `MagicType.js`. ToolboxView should be not aware of what features it may have.
brush feature is a typical example: https://github.com/apache/incubator-echarts/blob/next/src/component/toolbox/feature/Brush.ts#L47
You may refactor it in the next branch if you wish
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on pull request #12360: fix(toolbox): optimize stack icon toggle experience.
Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #12360:
URL: https://github.com/apache/incubator-echarts/pull/12360#issuecomment-668960600
Do it in 5.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org