You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/09/29 01:32:17 UTC
[GitHub] [incubator-mxnet] barry-jin opened a new pull request #20620: [WIP][API] Add floor_divide
barry-jin opened a new pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620
## Description ##
Add floor_divide
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20620: [API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-951499161
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20620: [API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-951448023
Jenkins CI successfully triggered : [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20620: [WIP][API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-950395020
Jenkins CI successfully triggered : [centos-gpu, website, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20620: [WIP][API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-950394993
@mxnet-bot run ci [centos-gpu, website, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20620: [API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-954407635
@mxnet-bot run ci [centos-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20620: [WIP][API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-929748675
Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, website, miscellaneous, windows-cpu, centos-gpu, windows-gpu, unix-gpu, sanity, edge, unix-cpu, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20620: [API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-951447975
@mxnet-bot run ci [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20620: [API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#discussion_r737663396
##########
File path: tests/python/unittest/test_numpy_interoperability.py
##########
@@ -1579,6 +1579,13 @@ def _add_workload_fmod(array_pool):
OpArgMngr.add_workload('fmod', array_pool['4x1'], array_pool['1x1x0'])
+def _add_workload_floor_divide(array_pool):
+ OpArgMngr.add_workload('floor_divide', array_pool['4x1'], array_pool['1x2'])
Review comment:
does it test for the negative values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20620: [API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-953477435
@mxnet-bot run ci [centos-gpu, centos-cpu, unix-cpu, unix-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20620: [API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-953477475
Jenkins CI successfully triggered : [centos-gpu, unix-cpu, centos-cpu, website, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20620: [API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-951499104
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20620: [WIP][API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-950513120
@mxnet-bot run ci [centos-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20620: [WIP][API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-950513166
Jenkins CI successfully triggered : [website, centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20620: [API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20620: [API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-954407671
Jenkins CI successfully triggered : [unix-gpu, centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20620: [WIP][API] Add floor_divide
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20620:
URL: https://github.com/apache/incubator-mxnet/pull/20620#issuecomment-929748675
Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, website, miscellaneous, windows-cpu, centos-gpu, windows-gpu, unix-gpu, sanity, edge, unix-cpu, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org