You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/03 20:41:16 UTC
[GitHub] [arrow] wolfeidau opened a new pull request, #13059: ARROW-16450: [Go][Docs] Include error handling in csv examples
wolfeidau opened a new pull request, #13059:
URL: https://github.com/apache/arrow/pull/13059
As per the tests I have added checks in the examples as this tripped me up while dealing with nulls in my CSVs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13059: ARROW-16450: [Go][Docs] Include error handling in csv examples
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13059:
URL: https://github.com/apache/arrow/pull/13059#issuecomment-1120836043
Benchmark runs are scheduled for baseline = 19c66d822d9f6347c9fd5b2222e434739e48ec3b and contender = 1dba9fb79eb7800556e387a1cf4851912ce7d724. 1dba9fb79eb7800556e387a1cf4851912ce7d724 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/49d428bb57e0473e8669a0d92ebe3f92...efe420bb23284b39bce5e409d0c70c1a/)
[Finished :arrow_down:1.79% :arrow_up:0.66%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4ea5c2ccf41247e08a221ef75c335169...5083b50544314d5fab6ddb6c9c3cb2b1/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/eceb0c083f874d1db2ec47564a0621c2...fd151f3b35ce44e5ac4a2ef1074ea7cf/)
[Finished :arrow_down:1.38% :arrow_up:0.12%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f5efe3c4ee17435f8df7f8424d4340e1...ff266fb423434b9e8faad4cc6b81251f/)
Buildkite builds:
[Finished] [`1dba9fb7` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/706)
[Finished] [`1dba9fb7` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/703)
[Finished] [`1dba9fb7` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/692)
[Finished] [`1dba9fb7` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/708)
[Finished] [`19c66d82` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/705)
[Finished] [`19c66d82` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/702)
[Finished] [`19c66d82` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/691)
[Finished] [`19c66d82` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/707)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade closed pull request #13059: ARROW-16450: [Go][Docs] Include error handling in csv examples
Posted by GitBox <gi...@apache.org>.
zeroshade closed pull request #13059: ARROW-16450: [Go][Docs] Include error handling in csv examples
URL: https://github.com/apache/arrow/pull/13059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13059: ARROW-16450: [Go][Docs] Include error handling in csv examples
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13059:
URL: https://github.com/apache/arrow/pull/13059#issuecomment-1116597616
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wolfeidau commented on a diff in pull request #13059: ARROW-16450: [Go][Docs] Include error handling in csv examples
Posted by GitBox <gi...@apache.org>.
wolfeidau commented on code in PR #13059:
URL: https://github.com/apache/arrow/pull/13059#discussion_r865430756
##########
go/arrow/csv/reader_test.go:
##########
@@ -61,6 +62,11 @@ func Example() {
n++
}
+ err := r.Err()
+ if err != nil {
+ log.Fatal(err)
+ }
Review Comment:
I have added a comment describing why we are checking the error.
##########
go/arrow/csv/writer_test.go:
##########
@@ -81,6 +81,11 @@ func Example_writer() {
n++
}
+ err = r.Err()
+ if err != nil {
+ log.Fatal(err)
+ }
Review Comment:
As above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #13059: ARROW-16450: [Go][Docs] Include error handling in csv examples
Posted by GitBox <gi...@apache.org>.
zeroshade commented on PR #13059:
URL: https://github.com/apache/arrow/pull/13059#issuecomment-1118587121
@wolfeidau Perfectly fine. Thanks much for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wolfeidau commented on pull request #13059: ARROW-16450: [Go][Docs] Include error handling in csv examples
Posted by GitBox <gi...@apache.org>.
wolfeidau commented on PR #13059:
URL: https://github.com/apache/arrow/pull/13059#issuecomment-1117988002
I amended the commit rather than adding a new one, not sure if that is OK on this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13059: ARROW-16450: [Go][Docs] Include error handling in csv examples
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13059:
URL: https://github.com/apache/arrow/pull/13059#issuecomment-1116597531
https://issues.apache.org/jira/browse/ARROW-16450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a diff in pull request #13059: ARROW-16450: [Go][Docs] Include error handling in csv examples
Posted by GitBox <gi...@apache.org>.
zeroshade commented on code in PR #13059:
URL: https://github.com/apache/arrow/pull/13059#discussion_r864891322
##########
go/arrow/csv/reader_test.go:
##########
@@ -61,6 +62,11 @@ func Example() {
n++
}
+ err := r.Err()
+ if err != nil {
+ log.Fatal(err)
+ }
Review Comment:
I'd say add a comment here to be more informative and explicit about the error handling
##########
go/arrow/csv/writer_test.go:
##########
@@ -81,6 +81,11 @@ func Example_writer() {
n++
}
+ err = r.Err()
+ if err != nil {
+ log.Fatal(err)
+ }
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org