You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stephen Clouse <st...@theiqgroup.com> on 2002/06/21 01:47:50 UTC
[PATCH] make install: convince libtool to do What You Want (tm) with mod_dav_svn
This is related to an earlier posting and partial patch from Scott Lamb on June
2. I dug this up after encountering the same problem, where libtool, during
make install, complains about installing mod_dav_svn outside of
SUBVERSION_PREFIX/lib.
Attached is simply the second half of Scott's patch -- namely, a minor change to
build/gen_base.py to get the makefile to localize libdir and use the Apache
module directory when building/installing mod_dav_svn. I added this in the
handling for the custom = apache-mod directive, since it seems that this
environment change would be necessary any time you wanted to install a module
into Apache.
--
Stephen Clouse <st...@theiqgroup.com>
Senior Programmer, IQ Coordinator Project Lead
The IQ Group, Inc. <http://www.theiqgroup.com/>
Re: [PATCH] attempt #2: fix libtool bogosity with installing mod_dav_svn
Posted by Philip Martin <ph...@codematters.co.uk>.
Stephen Clouse <st...@theiqgroup.com> writes:
> Okay, this ought to work, and no worries about it being portable either :)
Applied in rev 2317.
I changed APMODLINK to LINK_APACHE_MOD for consistency with
COMPILE_APACHE_MOD.
--
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] attempt #2: fix libtool bogosity with installing
mod_dav_svn
Posted by David Summers <da...@summersoft.fay.ar.us>.
Well, rats, I just tried your patch but it doesn't solve my problem of
having to put the -L entries in when I compile. Oh well.
For some reason as of the last week or so I have to put a bunch of -L
library include directives to be able to compile correctly and generate
the lib*so.* stuff.
I also have not been able to figure out how to tell apxs to install into a
staging area other than the end result directory that it wants to put
mod_dav_svn.so into.
So I have to install two patches to the distributed code to be able to
generate an RPM (see the subversion.spec file in the distribution).
Thanks
- David Summers
On Fri, 21 Jun 2002, Stephen Clouse wrote:
> Okay, this ought to work, and no worries about it being portable either :)
>
>
--
David Wayne Summers "Linux: Because reboots are for upgrades!"
david@summersoft.fay.ar.us PGP Key: http://summersoft.fay.ar.us/~david/pgp.txt
PGP Key fingerprint = C0 E0 4F 50 DD A9 B6 2B 60 A1 31 7E D2 28 6D A8
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
[PATCH] attempt #2: fix libtool bogosity with installing mod_dav_svn
Posted by Stephen Clouse <st...@theiqgroup.com>.
Okay, this ought to work, and no worries about it being portable either :)
--
Stephen Clouse <st...@theiqgroup.com>
Senior Programmer, IQ Coordinator Project Lead
The IQ Group, Inc. <http://www.theiqgroup.com/>
Re: [PATCH] make install: convince libtool to do What You Want (tm) with mod_dav_svn
Posted by Stephen Clouse <st...@theiqgroup.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Fri, Jun 21, 2002 at 11:11:54PM +0100, Philip Martin wrote:
> > But then all those poor csh users are left out :) I can't think of a completely
> > portable way of doing this, unfortunately.
>
> I don't think make will run csh unless SHELL is set explictitly in the
> Makefile, so we can probably rely on some sort of Bourne or POSIX
> sh.
Ah, so we don't have to be *that* portable :)
Let me fix things up real quick and make an updated patch.
- --
Stephen Clouse <st...@theiqgroup.com>
Senior Programmer, IQ Coordinator Project Lead
The IQ Group, Inc. <http://www.theiqgroup.com/>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
iD8DBQE9E7LlA4aoazQ9p2cRAkccAJ9Pg4dg4vVng068ONaXVC1uxAQZDQCfc5i/
rZdBvAf157LAuVQk2qjo818=
=ntMJ
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] make install: convince libtool to do What You Want (tm) with mod_dav_svn
Posted by Philip Martin <ph...@codematters.co.uk>.
Stephen Clouse <st...@theiqgroup.com> writes:
> On Fri, Jun 21, 2002 at 03:41:12PM +0100, Philip Martin wrote:
> > That's a target-specific variable assignment. How portable is that?
> > It works using GNU make, but is the syntax compatible with other
> > makes?
>
> What? There are makes other than GNU? :P
>
> My other thought was a shell override like so:
>
> subversion/mod_dav_svn/mod_dav_svn.la: $(mod_dav_svn_DEPS)
> libdir=$(APACHE_LIBEXECDIR) cd subversion/mod_dav_svn etc....
>
> But then all those poor csh users are left out :) I can't think of a completely
> portable way of doing this, unfortunately.
I don't think make will run csh unless SHELL is set explictitly in the
Makefile, so we can probably rely on some sort of Bourne or POSIX
sh. So as you suggest
var=val command
or maybe even
(var = val; export var; command)
I don't know which is the most portable, just as I don't know if
target-specific variables are portable :-(
--
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] make install: convince libtool to do What You Want (tm) with mod_dav_svn
Posted by Stephen Clouse <st...@theiqgroup.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Fri, Jun 21, 2002 at 04:32:30PM -0500, Stephen Clouse wrote:
> My other thought was a shell override like so:
Ah, wait, I should have stopped myself. Behold the rub:
LINK = $(LIBTOOL) $(LTFLAGS) --mode=link $(LT_LDFLAGS) $(COMPILE) $(LDFLAGS) \
-rpath $(libdir)
^^^^^^^^^
It's not an environment variable, it's a make variable.
Any good portable way for altering that on a per-target basis?
- --
Stephen Clouse <st...@theiqgroup.com>
Senior Programmer, IQ Coordinator Project Lead
The IQ Group, Inc. <http://www.theiqgroup.com/>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
iD8DBQE9E75AA4aoazQ9p2cRAoiFAKCmzMK7i5fDlXooo1rLfHs4aYkx4wCfR1C3
WAVMWOmVLAVA5vRfJKvyyDM=
=STL9
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] make install: convince libtool to do What You Want (tm)
with mod_dav_svn
Posted by David Mankin <ma...@ants.com>.
On Fri, 21 Jun 2002, Stephen Clouse wrote:
> My other thought was a shell override like so:
>
> subversion/mod_dav_svn/mod_dav_svn.la: $(mod_dav_svn_DEPS)
> libdir=$(APACHE_LIBEXECDIR) cd subversion/mod_dav_svn etc....
>
> But then all those poor csh users are left out :) I can't think of a completely
> portable way of doing this, unfortunately.
>
I don't know if it will work for this, but someone a while back pointed
out the "env" command which is available to do the same thing for both
shells. I think your line would be
subversion/mod_dav_svn/mod_dav_svn.la: $(mod_dav_svn_DEPS)
env libdir=$(APACHE_LIBEXECDIR) cd subversion/mod_dav_svn etc.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] make install: convince libtool to do What You Want (tm) with mod_dav_svn
Posted by Stephen Clouse <st...@theiqgroup.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Fri, Jun 21, 2002 at 03:41:12PM +0100, Philip Martin wrote:
> That's a target-specific variable assignment. How portable is that?
> It works using GNU make, but is the syntax compatible with other
> makes?
What? There are makes other than GNU? :P
My other thought was a shell override like so:
subversion/mod_dav_svn/mod_dav_svn.la: $(mod_dav_svn_DEPS)
libdir=$(APACHE_LIBEXECDIR) cd subversion/mod_dav_svn etc....
But then all those poor csh users are left out :) I can't think of a completely
portable way of doing this, unfortunately.
- --
Stephen Clouse <st...@theiqgroup.com>
Senior Programmer, IQ Coordinator Project Lead
The IQ Group, Inc. <http://www.theiqgroup.com/>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
iD8DBQE9E5tuA4aoazQ9p2cRAju5AJ9K+hAFDy/yvAR8uArjT6KhF0S/ygCfRG48
SpKz9mo+wsLKTgAUgdqGGHE=
=vsw2
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] make install: convince libtool to do What You Want (tm) with mod_dav_svn
Posted by Philip Martin <ph...@codematters.co.uk>.
Stephen Clouse <st...@theiqgroup.com> writes:
> 2. I dug this up after encountering the same problem, where libtool, during
> make install, complains about installing mod_dav_svn outside of
> SUBVERSION_PREFIX/lib.
[snip]
> Index: ./build/gen_base.py
> ===================================================================
> --- ./build/gen_base.py
> +++ ./build/gen_base.py Thu Jun 20 20:33:11 2002
> @@ -191,6 +191,9 @@
> custom = self.parser.get(target, 'custom')
> if custom == 'apache-mod':
> # special build, needing Apache includes
> + # also must tweak libtool to install into Apache module dir
> + self.ofile.write('# convince libtool to install into Apache module dir\n')
> + self.ofile.write('%s: libdir=$(APACHE_LIBEXECDIR)\n\n' % (tpath))
That's a target-specific variable assignment. How portable is that?
It works using GNU make, but is the syntax compatible with other
makes?
Please write a log message :-)
--
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org